Patchwork Committed: handle negative numbers in gcc-gdb-test.exp

login
register
mail settings
Submitter Hans-Peter Nilsson
Date Nov. 24, 2012, 9:41 a.m.
Message ID <alpine.BSF.2.02.1211240440010.50510@dair.pair.com>
Download mbox | patch
Permalink /patch/201447/
State New
Headers show

Comments

Hans-Peter Nilsson - Nov. 24, 2012, 9:41 a.m.
Without this, I got weird ERRORs and those Tcl backtraces you come
to hate, instead of the expected FAILs.  Committed as obvious after
running a failing guality test and obvserving the intended change.
(Well ok, *adding an explanatory comment* is apparently not obvious,
but I'll take that liberty...)

testsuite:
	* lib/gcc-gdb-test.exp (gdb-test): Pass -- as first argument
	to to send_log.


brgds, H-P

Patch

Index: gcc/testsuite/lib/gcc-gdb-test.exp
===================================================================
--- gcc/testsuite/lib/gcc-gdb-test.exp	(revision 192677)
+++ gcc/testsuite/lib/gcc-gdb-test.exp	(working copy)
@@ -74,7 +74,9 @@  proc gdb-test { args } {
 	    if { $first == $second } {
 		pass "$testname"
 	    } else {
-		send_log "$first != $second\n"
+		# We need the -- to disambiguate $first from an option,
+		# as it may be negative.
+		send_log -- "$first != $second\n"
 		fail "$testname"
 	    }
 	    remote_close target