Patchwork [3.5.yuz,extended,stable] Patch "target: Re-add explict zeroing of INQUIRY bounce buffer" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Nov. 23, 2012, 2:26 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/201329/
State New
Headers show


Herton Ronaldo Krzesinski - Nov. 23, 2012, 2:26 p.m.
This is a note to let you know that I have just added a patch titled

    target: Re-add explict zeroing of INQUIRY bounce buffer

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



From 0d32695d8203dad57dcbdc2d7cb91a99b2725185 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <>
Date: Wed, 31 Oct 2012 22:04:26 -0700
Subject: [PATCH 1/5] target: Re-add explict zeroing of INQUIRY bounce buffer

commit dea5f0998aa82bdeca260b87c653db11e91329b2 upstream.

This patch fixes a regression in spc_emulate_inquiry() code where the
local scope bounce buffer was no longer getting it's memory zeroed,
causing various problems with SCSI initiators that depend upon areas
of INQUIRY EVPD=0x83 payload having been zeroed.

This bug was introduced with the following v3.7-rc1 patch + CC'ed
stable commit:

commit ffe7b0e9326d9c68f5688bef691dd49f1e0d3651
Author: Paolo Bonzini <>
Date:   Fri Sep 7 17:30:38 2012 +0200

    target: support zero allocation length in INQUIRY

Go ahead and re-add the missing memset of bounce buffer memory to be
copied into the outgoing se_cmd descriptor kmapped SGL payload.

Reported-by: Kelsey Prantis <>
Cc: Kelsey Prantis <>
Cc: Paolo Bonzini <>
Cc: Andy Grover <>
Signed-off-by: Nicholas Bellinger <>
[ herton: code to be patched is in target_core_cdb.c on 3.5 ]
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/target/target_core_cdb.c |    2 ++
 1 file changed, 2 insertions(+)



diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
index 3dc3393..dd09f0f 100644
--- a/drivers/target/target_core_cdb.c
+++ b/drivers/target/target_core_cdb.c
@@ -610,6 +610,8 @@  int target_emulate_inquiry(struct se_cmd *cmd)
 	unsigned char buf[SE_INQUIRY_BUF];
 	int p, ret;

+	memset(buf, 0, SE_INQUIRY_BUF);
 	if (dev == tpg->tpg_virt_lun0.lun_se_dev)
 		buf[0] = 0x3f; /* Not connected */