Patchwork [1/1] Legacy qemu-kvm options have no argument

login
register
mail settings
Submitter Marcelo Tosatti
Date Nov. 23, 2012, 12:41 p.m.
Message ID <c6e88b3b27b411e3f1c924deb8b71b20f8a11107.1353674496.git.mtosatti@redhat.com>
Download mbox | patch
Permalink /patch/201311/
State New
Headers show

Comments

Marcelo Tosatti - Nov. 23, 2012, 12:41 p.m.
From: Bruce Rogers <brogers@suse.com>

The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
should be marked as having no argument.

Signed-off-by: Bruce Rogers <brogers@suse.com>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 qemu-options.hx |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Andreas Färber - Nov. 23, 2012, 4:45 p.m.
Am 23.11.2012 13:41, schrieb Marcelo Tosatti:
> From: Bruce Rogers <brogers@suse.com>
> 
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Missing a

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

from earlier today.

Andreas

> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> ---
>  qemu-options.hx |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..fbcf079 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
>  ETEXI
>  
>  HXCOMM Deprecated by -machine accel=tcg property
> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated by kvm-pit driver properties
> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
>      "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated (ignored)
> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>  
>  HXCOMM Deprecated (ignored)
>  DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
>

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 9bb29d3..fbcf079 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2918,17 +2918,17 @@  Enable FIPS 140-2 compliance mode.
 ETEXI
 
 HXCOMM Deprecated by -machine accel=tcg property
-DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
+DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
 
 HXCOMM Deprecated by kvm-pit driver properties
-DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
+DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
     "", QEMU_ARCH_I386)
 
 HXCOMM Deprecated (ignored)
-DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
+DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
 
 HXCOMM Deprecated by -machine kernel_irqchip=on|off property
-DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
+DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
 
 HXCOMM Deprecated (ignored)
 DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)