From patchwork Thu Nov 22 20:02:56 2012
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [2/2] block: clarify comment about IF_IDE = 0
Date: Thu, 22 Nov 2012 10:02:56 -0000
From: Christian Borntraeger <borntraeger@de.ibm.com>
X-Patchwork-Id: 201182
Message-Id: <1353614576-21015-3-git-send-email-borntraeger@de.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, 
 Anthony Liguori <aliguori@us.ibm.com>,
 Igor Mitsyanko <i.mitsyanko@samsung.com>,
 qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Jens Freimann <jfrei@linux.vnet.ibm.com>,
 Stefan Hajnoczi <stefanha@redhat.com>,
 Cornelia Huck <cornelia.huck@de.ibm.com>,
 Andreas Faerber <afaerber@suse.de>, Einar Lueck <elelueck@de.ibm.com>

Lets make the comment regarding IF_IDE more precise
why it must be 0.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

---
blockdev.h |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/blockdev.h b/blockdev.h
index 1c9ca6a..d73d552 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -19,7 +19,11 @@ void blockdev_auto_del(BlockDriverState *bs);
 
 typedef enum {
     IF_DEFAULT = -1,            /* for use with drive_add() only */
-    IF_IDE,                     /* machines without block_default_type get 0 */
+    /*
+     * IF_IDE must be zero, because we want QEMUMachine member
+     * block_default_type to default-initialize to IF_IDE
+     */
+    IF_IDE = 0,
     IF_NONE,
     IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
     IF_COUNT