Patchwork Marvell 88E1118 interrupt fix

login
register
mail settings
Submitter Ron Madrid
Date Jan. 23, 2009, 8:04 p.m.
Message ID <1232741050-6960-1-git-send-email-ron_madrid@sbcglobal.net>
Download mbox | patch
Permalink /patch/20118/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Ron Madrid - Jan. 23, 2009, 8:04 p.m.
This patch adjusts the LED control so that interrupt lines are not reading LEDs
and effectively causing indefinite interrupts to the controller.

Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>
---
 drivers/net/tsec.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
David Miller - Jan. 26, 2009, 8:21 p.m.
From: Ron Madrid <ron_madrid@sbcglobal.net>
Date: Fri, 23 Jan 2009 12:04:10 -0800

> This patch adjusts the LED control so that interrupt lines are not reading LEDs
> and effectively causing indefinite interrupts to the controller.
> 
> Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>

There is no drivers/net/tsec.c in the tree.  I can't even find
'phy_info_M88E1118' in any source file.

What are you generating this patch against?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ron Madrid - Jan. 26, 2009, 8:34 p.m.
I'm sorry.  I sent this to the wrong mail list.  My apologies.

Ron


--- On Mon, 1/26/09, David Miller <davem@davemloft.net> wrote:

> From: David Miller <davem@davemloft.net>
> Subject: Re: [PATCH] Marvell 88E1118 interrupt fix
> To: ron_madrid@sbcglobal.net
> Cc: netdev@vger.kernel.org
> Date: Monday, January 26, 2009, 12:21 PM
> From: Ron Madrid <ron_madrid@sbcglobal.net>
> Date: Fri, 23 Jan 2009 12:04:10 -0800
> 
> > This patch adjusts the LED control so that interrupt
> lines are not reading LEDs
> > and effectively causing indefinite interrupts to the
> controller.
> > 
> > Signed-off-by: Ron Madrid
> <ron_madrid@sbcglobal.net>
> 
> There is no drivers/net/tsec.c in the tree.  I can't
> even find
> 'phy_info_M88E1118' in any source file.
> 
> What are you generating this patch against?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index d7da081..c9aa29d 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -1141,6 +1141,9 @@  struct phy_info phy_info_M88E1118 = {
 		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
 		{0x16, 0x0002, NULL}, /* Change Page Number */
 		{0x15, 0x1070, NULL}, /* Delay RGMII TX and RX */
+		{0x16, 0x0003, NULL}, /* Change Page Number */
+		{0x10, 0x021e, NULL}, /* Adjust LED control */
+		{0x16, 0x0000, NULL}, /* Change Page Number */
 		{MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
 		{MIIM_ANAR, MIIM_ANAR_INIT, NULL},
 		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
@@ -1152,6 +1155,7 @@  struct phy_info phy_info_M88E1118 = {
 		/* Status is read once to clear old link state */
 		{MIIM_STATUS, miim_read, NULL},
 		/* Auto-negotiate */
+		{MIIM_STATUS, miim_read, &mii_parse_sr},
 		/* Read the status */
 		{MIIM_88E1011_PHY_STATUS, miim_read,
 		 &mii_parse_88E1011_psr},