From patchwork Thu Nov 22 17:30:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 201095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 97AC62C0168 for ; Fri, 23 Nov 2012 04:30:33 +1100 (EST) Received: from localhost ([::1]:60633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbabc-0002JH-Hv for incoming@patchwork.ozlabs.org; Thu, 22 Nov 2012 12:30:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbabR-0002Iu-Mf for qemu-devel@nongnu.org; Thu, 22 Nov 2012 12:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbabJ-0008M0-7k for qemu-devel@nongnu.org; Thu, 22 Nov 2012 12:30:15 -0500 Received: from goliath.siemens.de ([192.35.17.28]:15717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbabI-0008E9-Un for qemu-devel@nongnu.org; Thu, 22 Nov 2012 12:30:09 -0500 Received: from mail1.siemens.de (localhost [127.0.0.1]) by goliath.siemens.de (8.13.6/8.13.6) with ESMTP id qAMHU2NR025167; Thu, 22 Nov 2012 18:30:02 +0100 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id qAMHU2pQ018889; Thu, 22 Nov 2012 18:30:02 +0100 Message-ID: <50AE611A.50702@siemens.com> Date: Thu, 22 Nov 2012 18:30:02 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Anthony Liguori , qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 192.35.17.28 Cc: Paolo Bonzini , Dietmar Maurer , Luiz Capitulino Subject: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The vm clock may be stopped, and then we won't get open events anymore. Seen with QMP sessions. Reported-by: Dietmar Maurer Tested-by: Luiz Capitulino Signed-off-by: Jan Kiszka --- qemu-char.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 88f4025..242b799 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void *opaque) void qemu_chr_generic_open(CharDriverState *s) { if (s->open_timer == NULL) { - s->open_timer = qemu_new_timer_ms(vm_clock, + s->open_timer = qemu_new_timer_ms(rt_clock, qemu_chr_fire_open_event, s); - qemu_mod_timer(s->open_timer, qemu_get_clock_ms(vm_clock) - 1); + qemu_mod_timer(s->open_timer, qemu_get_clock_ms(rt_clock) - 1); } }