Patchwork [v2] gstreamer: Added option to disable plugin

login
register
mail settings
Submitter Tim Sheridan
Date Nov. 22, 2012, 1:53 p.m.
Message ID <98E3058E5505294895CA69F176CAD66272CE97@LEMAIL01.le.imgtec.org>
Download mbox | patch
Permalink /patch/201047/
State Superseded
Headers show

Comments

Tim Sheridan - Nov. 22, 2012, 1:53 p.m.
The plugin registry can take a while to be generated when GStreamer is initialized. Turning it off speeds up GStreamer application launch times. Default behaviour is unchanged.

Signed-off-by: Tim Sheridan <tim.sheridan@imgtec.com>
---
 package/multimedia/gstreamer/Config.in    |    9 +++++++++
 package/multimedia/gstreamer/gstreamer.mk |    3 ++- 
 2 files changed, 11 insertions(+), 1 deletions(-)

--
1.7.1
Arnout Vandecappelle - Nov. 24, 2012, 11:51 p.m.
Hi Tim,

  The whitespace in your patch is messed up by your e-mail client.  Please use
git send-email to avoid this.


On 22/11/12 14:53, Tim Sheridan wrote:
> The plugin registry can take a while to be generated when GStreamer is initialized. Turning it off speeds up GStreamer application launch times. Default behaviour is unchanged.

  Please wrap the commit message at +- 72 characters

>
> Signed-off-by: Tim Sheridan<tim.sheridan@imgtec.com>
> ---
>   package/multimedia/gstreamer/Config.in    |    9 +++++++++
>   package/multimedia/gstreamer/gstreamer.mk |    3 ++-
>   2 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/package/multimedia/gstreamer/Config.in b/package/multimedia/gstreamer/Config.in
> index 4d279b8..e946b18 100644
> --- a/package/multimedia/gstreamer/Config.in
> +++ b/package/multimedia/gstreamer/Config.in
> @@ -16,5 +16,14 @@ config BR2_PACKAGE_GSTREAMER_GST_DEBUG
>            in gstreamer. This has limited CPU overhead, but does
>            increase the rootfs size somewhat.
>
> +config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
> +       bool "enable plugin registry"
> +       default y
> +       depends on BR2_PACKAGE_GSTREAMER
> +       help
> +         Enable support for the GStreamer plugin registry.
> +         This may increase the launch-time for a GStreamer
> +         application.

  The Config.in things should be indented with 1 tab, help text with
1 tab and 2 spaces.  Wrapping should be at 80 characters, with the tab
counting as 8 characters.

> +
>   comment "gstreamer requires a toolchain with WCHAR support"
>          depends on !BR2_USE_WCHAR
> diff --git a/package/multimedia/gstreamer/gstreamer.mk b/package/multimedia/gstreamer/gstreamer.mk
> index a9841b1..b87f029 100644
> --- a/package/multimedia/gstreamer/gstreamer.mk
> +++ b/package/multimedia/gstreamer/gstreamer.mk
> @@ -21,7 +21,8 @@ GSTREAMER_CONF_OPT = \
>                  --disable-tests \
>                  --disable-failing-tests \
>                  --disable-loadsave \
> -               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug)
> +               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug) \
> +               $(if
> + $(BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY),,--disable-registry)

  No need to split this line, even if it goes over 80 characters. It's less readable
when split.


  All my comments are just whitespace-related, so:

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


  Regards,
  Arnout

>
>   GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf
>
> --
> 1.7.1

Patch

diff --git a/package/multimedia/gstreamer/Config.in b/package/multimedia/gstreamer/Config.in
index 4d279b8..e946b18 100644
--- a/package/multimedia/gstreamer/Config.in
+++ b/package/multimedia/gstreamer/Config.in
@@ -16,5 +16,14 @@  config BR2_PACKAGE_GSTREAMER_GST_DEBUG
          in gstreamer. This has limited CPU overhead, but does
          increase the rootfs size somewhat.
 
+config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
+       bool "enable plugin registry"
+       default y
+       depends on BR2_PACKAGE_GSTREAMER
+       help
+         Enable support for the GStreamer plugin registry.
+         This may increase the launch-time for a GStreamer
+         application.
+
 comment "gstreamer requires a toolchain with WCHAR support"
        depends on !BR2_USE_WCHAR
diff --git a/package/multimedia/gstreamer/gstreamer.mk b/package/multimedia/gstreamer/gstreamer.mk
index a9841b1..b87f029 100644
--- a/package/multimedia/gstreamer/gstreamer.mk
+++ b/package/multimedia/gstreamer/gstreamer.mk
@@ -21,7 +21,8 @@  GSTREAMER_CONF_OPT = \
                --disable-tests \
                --disable-failing-tests \
                --disable-loadsave \
-               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug)
+               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug) \
+               $(if 
+ $(BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY),,--disable-registry)
 
 GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf