Patchwork [3.5.yuz,extended,stable] Patch "dmaengine: sirf: fix a typo in moving running dma_desc to" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Nov. 22, 2012, 4:48 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/200974/
State New
Headers show


Herton Ronaldo Krzesinski - Nov. 22, 2012, 4:48 a.m.
This is a note to let you know that I have just added a patch titled

    dmaengine: sirf: fix a typo in moving running dma_desc to

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



From eec1114823c3fe41f36187f0fdc907048f49c144 Mon Sep 17 00:00:00 2001
From: Barry Song <>
Date: Thu, 27 Sep 2012 16:36:10 +0800
Subject: [PATCH] dmaengine: sirf: fix a typo in moving running dma_desc to
 active queue

commit 26fd12209c08fe947be1828896ef4ffc5bd0e6df upstream.

list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
undefined, we either should change it to:
list_move_tail(schan->, &schan->active)
list_move_tail(&sdesc->node, &schan->active)

Signed-off-by: Barry Song <>
Signed-off-by: Vinod Koul <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/dma/sirf-dma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
index 35a329d..c439489 100644
--- a/drivers/dma/sirf-dma.c
+++ b/drivers/dma/sirf-dma.c
@@ -109,7 +109,7 @@  static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan)
 	sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
 	/* Move the first queued descriptor to active list */
-	list_move_tail(&schan->queued, &schan->active);
+	list_move_tail(&sdesc->node, &schan->active);

 	/* Start the DMA transfer */
 	writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +