Patchwork [V3] Build system fix distclean error for pixman

login
register
mail settings
Submitter Wayne Xia
Date Nov. 22, 2012, 2:07 a.m.
Message ID <1353550066-3923-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/200923/
State New
Headers show

Comments

Wayne Xia - Nov. 22, 2012, 2:07 a.m.
Currently Makefile test if pixman have configure log, but the script directly
return error if that file do not exist. This patch fix it.

v2: print out the command.
v3: resend as a stand alone fix patch, add reviewer.

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - Nov. 22, 2012, 8:38 a.m.
On 22 November 2012 02:07, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>   Currently Makefile test if pixman have configure log, but the script directly
> return error if that file do not exist. This patch fix it.
>
> v2: print out the command.
> v3: resend as a stand alone fix patch, add reviewer.

Really v2/v3 info should go below '---' but never mind.

You didn't put "for-1.3" in the patch tag in the subject
so I have added it.

-- PMM
Wayne Xia - Nov. 22, 2012, 8:46 a.m.
> On 22 November 2012 02:07, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>>    Currently Makefile test if pixman have configure log, but the script directly
>> return error if that file do not exist. This patch fix it.
>>
>> v2: print out the command.
>> v3: resend as a stand alone fix patch, add reviewer.
>
> Really v2/v3 info should go below '---' but never mind.
>
> You didn't put "for-1.3" in the patch tag in the subject
> so I have added it.
>
> -- PMM
>
   Thanks for the correcting, by referencing to other patches for v1.3,
I changed the subject to PATCH for 1.3 V3, hope it can draw attention.
Stefan Hajnoczi - Nov. 22, 2012, 10:20 a.m.
On Thu, Nov 22, 2012 at 10:07:46AM +0800, Wenchao Xia wrote:
>   Currently Makefile test if pixman have configure log, but the script directly
> return error if that file do not exist. This patch fix it.
> 
> v2: print out the command.
> v3: resend as a stand alone fix patch, add reviewer.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Patch

diff --git a/Makefile b/Makefile
index 3e8d441..9ecbcbb 100644
--- a/Makefile
+++ b/Makefile
@@ -286,7 +286,7 @@  distclean: clean
 	for d in $(TARGET_DIRS) $(QEMULIBS); do \
 	rm -rf $$d || exit 1 ; \
         done
-	test -f pixman/config.log && make -C pixman distclean
+	if test -f pixman/config.log; then make -C pixman distclean; fi
 
 KEYMAPS=da     en-gb  et  fr     fr-ch  is  lt  modifiers  no  pt-br  sv \
 ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \