Patchwork [32/33] rrdtool: add license info

login
register
mail settings
Submitter Samuel Martin
Date Nov. 22, 2012, 12:18 a.m.
Message ID <1353543503-8952-33-git-send-email-s.martin49@gmail.com>
Download mbox | patch
Permalink /patch/200920/
State Superseded
Headers show

Comments

Samuel Martin - Nov. 22, 2012, 12:18 a.m.
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
 package/rrdtool/rrdtool.mk | 3 +++
 1 file changed, 3 insertions(+)
Baruch Siach - Nov. 22, 2012, 5:17 a.m.
Hi Samuel,

On Thu, Nov 22, 2012 at 01:18:22AM +0100, Samuel Martin wrote:
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
>  package/rrdtool/rrdtool.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/rrdtool/rrdtool.mk b/package/rrdtool/rrdtool.mk
> index 8799a85..4392b50 100644
> --- a/package/rrdtool/rrdtool.mk
> +++ b/package/rrdtool/rrdtool.mk
> @@ -6,6 +6,9 @@
>  
>  RRDTOOL_VERSION = 1.2.30
>  RRDTOOL_SITE = http://oss.oetiker.ch/rrdtool/pub
> +RRDTOOL_LICENSE = GPLv2+ with FLOSS license exceptions as explained in COPYRIGHT
> +RRDTOOL_LICENSE_FILES = COPYING

Shouldn't COPYRIGHT also be listed with the license files?

baruch

> +
>  RRDTOOL_DEPENDENCIES = host-pkgconf freetype libart libpng zlib
>  RRDTOOL_AUTORECONF = YES
>  RRDTOOL_INSTALL_STAGING = YES
Samuel Martin - Nov. 22, 2012, 10:07 a.m.
Hi Baruch, all,

2012/11/22 Baruch Siach <baruch@tkos.co.il>:
> Hi Samuel,
>
> On Thu, Nov 22, 2012 at 01:18:22AM +0100, Samuel Martin wrote:
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>>  package/rrdtool/rrdtool.mk | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/package/rrdtool/rrdtool.mk b/package/rrdtool/rrdtool.mk
>> index 8799a85..4392b50 100644
>> --- a/package/rrdtool/rrdtool.mk
>> +++ b/package/rrdtool/rrdtool.mk
>> @@ -6,6 +6,9 @@
>>
>>  RRDTOOL_VERSION = 1.2.30
>>  RRDTOOL_SITE = http://oss.oetiker.ch/rrdtool/pub
>> +RRDTOOL_LICENSE = GPLv2+ with FLOSS license exceptions as explained in COPYRIGHT
>> +RRDTOOL_LICENSE_FILES = COPYING
>
> Shouldn't COPYRIGHT also be listed with the license files?
The Copyright file just tells us "wrt the license, you can do that and
that, but not that with this software",
with some real use case.

Shall we consider as part of the license files?

Regards,
Arnout Vandecappelle - Nov. 24, 2012, 8:09 p.m.
On 22/11/12 11:07, Samuel Martin wrote:
> Hi Baruch, all,
>
> 2012/11/22 Baruch Siach<baruch@tkos.co.il>:
> > Hi Samuel,
> >
> > On Thu, Nov 22, 2012 at 01:18:22AM +0100, Samuel Martin wrote:
> >>
> >> Signed-off-by: Samuel Martin<s.martin49@gmail.com>
> >> ---
> >>   package/rrdtool/rrdtool.mk | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/package/rrdtool/rrdtool.mk b/package/rrdtool/rrdtool.mk
> >> index 8799a85..4392b50 100644
> >> --- a/package/rrdtool/rrdtool.mk
> >> +++ b/package/rrdtool/rrdtool.mk
> >> @@ -6,6 +6,9 @@
> >>
> >>   RRDTOOL_VERSION = 1.2.30
> >>   RRDTOOL_SITE = http://oss.oetiker.ch/rrdtool/pub
> >> +RRDTOOL_LICENSE = GPLv2+ with FLOSS license exceptions as explained in COPYRIGHT
> >> +RRDTOOL_LICENSE_FILES = COPYING
> >
> > Shouldn't COPYRIGHT also be listed with the license files?
> The Copyright file just tells us "wrt the license, you can do that and
> that, but not that with this software",
> with some real use case.
>
> Shall we consider as part of the license files?

  Since you refer to it in the RRDTOOL_LICENSE, yes the COPYRIGHT file
should be included.

  Note that "GPLv2+ with exceptions" is probably enough, since the
user should anyway look at COPYRIGHT to find out the details.

  Regards,
  Arnout

Patch

diff --git a/package/rrdtool/rrdtool.mk b/package/rrdtool/rrdtool.mk
index 8799a85..4392b50 100644
--- a/package/rrdtool/rrdtool.mk
+++ b/package/rrdtool/rrdtool.mk
@@ -6,6 +6,9 @@ 
 
 RRDTOOL_VERSION = 1.2.30
 RRDTOOL_SITE = http://oss.oetiker.ch/rrdtool/pub
+RRDTOOL_LICENSE = GPLv2+ with FLOSS license exceptions as explained in COPYRIGHT
+RRDTOOL_LICENSE_FILES = COPYING
+
 RRDTOOL_DEPENDENCIES = host-pkgconf freetype libart libpng zlib
 RRDTOOL_AUTORECONF = YES
 RRDTOOL_INSTALL_STAGING = YES