From patchwork Wed Nov 21 18:40:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greta Yorsh X-Patchwork-Id: 200826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B43E52C008E for ; Thu, 22 Nov 2012 05:40:42 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354128043; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=cJcm9mWEjN0suJHBiMfk LBTvhcs=; b=YrViA5ZZEDkrpjXOepCooxxvul4wIEKxv89jg60zbn4Q4xl6kc6f VdxotfvEOzqsV8svj6uFGE3Lj4FSD+vhBHZumymHNm1r9uqMQu/9Oeftqsg0Uk/R PwKHHJ7d4d+jhon4HdzdxfBwGebhUB6H7doZQLGPXpPauISfeX/YrEo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:MIME-Version:X-MC-Unique:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=NTfztSYThVTbnG+0aXyPIwUxpWzfWfFs2e/rYBM+88bSyOg/pk9gRpc6I2KTmo 5IpeLhODzKLl9xUXsaF6JOoZsIBxHnbiwgrO5KpQYGy9I9H6WnrKH6KnZE+SfOMY mf+upsjo6cOJhUnYF2d871f8bISqiPjd523ftVjGCPkzQ=; Received: (qmail 3214 invoked by alias); 21 Nov 2012 18:40:25 -0000 Received: (qmail 3119 invoked by uid 22791); 21 Nov 2012 18:40:22 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW, TW_QE X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 18:40:12 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 21 Nov 2012 18:40:11 +0000 Received: from e103227vm ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 21 Nov 2012 18:40:09 +0000 From: "Greta Yorsh" To: "GCC Patches" Cc: "Ramana Radhakrishnan" , "Richard Earnshaw" , , Subject: [ARM, PATCH] TARGET_LDRD reject Thumb1 targets Date: Wed, 21 Nov 2012 18:40:15 -0000 Message-ID: <000601cdc817$a63003e0$f2900ba0$@yorsh@arm.com> MIME-Version: 1.0 X-MC-Unique: 112112118401100801 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch adjusts the definition of TARGET_LDRD to false on Thumb1 targets, as suggested here: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02048.html No regression on qemu for arm none-eabi with arch=armv5t/armv7-a mode=thumb/arm. Ok for trunk? Thanks, Greta ChangeLog 2012-11-21 Greta Yorsh * config/arm/arm.h (TARGET_LDRD): Reject Thumb1 targets. diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index 5f34f2a..1adcf9f 100644 --- a/gcc/config/arm/arm.h +++ b/gcc/config/arm/arm.h @@ -252,7 +252,6 @@ extern void (*arm_lang_output_object_attributes_hook)(void); #define TARGET_BACKTRACE (leaf_function_p () \ ? TARGET_TPCS_LEAF_FRAME \ : TARGET_TPCS_FRAME) -#define TARGET_LDRD (arm_arch5e && ARM_DOUBLEWORD_ALIGN) #define TARGET_AAPCS_BASED \ (arm_abi != ARM_ABI_APCS && arm_abi != ARM_ABI_ATPCS) @@ -269,6 +268,9 @@ extern void (*arm_lang_output_object_attributes_hook)(void); /* Thumb-1 only. */ #define TARGET_THUMB1_ONLY (TARGET_THUMB1 && !arm_arch_notm) +#define TARGET_LDRD (arm_arch5e && ARM_DOUBLEWORD_ALIGN \ + && !TARGET_THUMB1) + /* The following two macros concern the ability to execute coprocessor instructions for VFPv3 or NEON. TARGET_VFP3/TARGET_VFPD32 are currently only ever tested when we know we are generating for VFP hardware; we need