Patchwork [3/6] lib: fwts_framework: show_progress flag should be a bool

login
register
mail settings
Submitter Colin King
Date Nov. 21, 2012, 4:24 p.m.
Message ID <1353515085-8053-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/200801/
State Accepted
Headers show

Comments

Colin King - Nov. 21, 2012, 4:24 p.m.
From: Colin Ian King <colin.king@canonical.com>

Make show_progress a bool type rather than an int in fwts_framework

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_framework.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Nov. 22, 2012, 6:15 a.m.
On Thu, Nov 22, 2012 at 12:24 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make show_progress a bool type rather than an int in fwts_framework
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_framework.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 693d993..32bab8c 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -124,7 +124,7 @@ typedef struct {
>         fwts_list total_taglist;                /* List of tags found when running all tests */
>
>         fwts_firmware_type firmware_type;       /* Type of firmware */
> -       int show_progress;                      /* Show progress while running current test */
> +       bool show_progress;                     /* Show progress while running current test */
>
>         fwts_log_type   log_type;               /* Output log type, default is plain text ASCII */
>  } fwts_framework;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Nov. 27, 2012, 2:47 p.m.
On 11/22/2012 12:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make show_progress a bool type rather than an int in fwts_framework
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/include/fwts_framework.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 693d993..32bab8c 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -124,7 +124,7 @@ typedef struct {
>   	fwts_list total_taglist;		/* List of tags found when running all tests */
>
>   	fwts_firmware_type firmware_type;	/* Type of firmware */
> -	int show_progress;			/* Show progress while running current test */
> +	bool show_progress;			/* Show progress while running current test */
>
>   	fwts_log_type	log_type;		/* Output log type, default is plain text ASCII */
>   } fwts_framework;
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
index 693d993..32bab8c 100644
--- a/src/lib/include/fwts_framework.h
+++ b/src/lib/include/fwts_framework.h
@@ -124,7 +124,7 @@  typedef struct {
 	fwts_list total_taglist;		/* List of tags found when running all tests */
 
 	fwts_firmware_type firmware_type;	/* Type of firmware */
-	int show_progress;			/* Show progress while running current test */
+	bool show_progress;			/* Show progress while running current test */
 
 	fwts_log_type	log_type;		/* Output log type, default is plain text ASCII */
 } fwts_framework;