Patchwork [4/6] lib: fwts_framework: print_summary should be a bool

login
register
mail settings
Submitter Colin King
Date Nov. 21, 2012, 4:24 p.m.
Message ID <1353515085-8053-5-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/200799/
State Accepted
Headers show

Comments

Colin King - Nov. 21, 2012, 4:24 p.m.
From: Colin Ian King <colin.king@canonical.com>

Make print_summary a bool type, set it using true rather than 1

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_framework.h |    2 +-
 src/lib/src/fwts_framework.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Keng-Yu Lin - Nov. 22, 2012, 6:16 a.m.
On Thu, Nov 22, 2012 at 12:24 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make print_summary a bool type, set it using true rather than 1
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_framework.h |    2 +-
>  src/lib/src/fwts_framework.c     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 32bab8c..0d9e2aa 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -117,7 +117,7 @@ typedef struct {
>         uint32_t        total_run;              /* total number of major tests run */
>
>         int minor_test_progress;                /* Percentage completion of current test */
> -       int print_summary;                      /* Print summary of results at end of test runs */
> +       bool print_summary;                     /* Print summary of results at end of test runs */
>         fwts_log_level failed_level;            /* Bit mask of failed levels in test run */
>
>         fwts_list test_taglist;                 /* List of tags found when running all minor tests */
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index e515e05..c940305 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -489,7 +489,7 @@ static int fwts_framework_run_test(fwts_framework *fw, fwts_framework_test *test
>
>         /* Not a utility test?, then we require a test summary at end of the test run */
>         if (!(test->flags & FWTS_FLAG_UTILS))
> -               fw->print_summary = 1;
> +               fw->print_summary = true;
>
>         if (test->ops->description) {
>                 fwts_log_heading(fw, "%s", test->ops->description);
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Nov. 27, 2012, 2:47 p.m.
On 11/22/2012 12:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make print_summary a bool type, set it using true rather than 1
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/include/fwts_framework.h |    2 +-
>   src/lib/src/fwts_framework.c     |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 32bab8c..0d9e2aa 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -117,7 +117,7 @@ typedef struct {
>   	uint32_t	total_run;		/* total number of major tests run */
>
>   	int minor_test_progress;		/* Percentage completion of current test */
> -	int print_summary;			/* Print summary of results at end of test runs */
> +	bool print_summary;			/* Print summary of results at end of test runs */
>   	fwts_log_level failed_level;		/* Bit mask of failed levels in test run */
>
>   	fwts_list test_taglist;			/* List of tags found when running all minor tests */
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index e515e05..c940305 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -489,7 +489,7 @@ static int fwts_framework_run_test(fwts_framework *fw, fwts_framework_test *test
>
>   	/* Not a utility test?, then we require a test summary at end of the test run */
>   	if (!(test->flags & FWTS_FLAG_UTILS))
> -		fw->print_summary = 1;
> +		fw->print_summary = true;
>
>   	if (test->ops->description) {
>   		fwts_log_heading(fw, "%s", test->ops->description);
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
index 32bab8c..0d9e2aa 100644
--- a/src/lib/include/fwts_framework.h
+++ b/src/lib/include/fwts_framework.h
@@ -117,7 +117,7 @@  typedef struct {
 	uint32_t	total_run;		/* total number of major tests run */
 
 	int minor_test_progress;		/* Percentage completion of current test */
-	int print_summary;			/* Print summary of results at end of test runs */
+	bool print_summary;			/* Print summary of results at end of test runs */
 	fwts_log_level failed_level;		/* Bit mask of failed levels in test run */
 
 	fwts_list test_taglist;			/* List of tags found when running all minor tests */
diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index e515e05..c940305 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -489,7 +489,7 @@  static int fwts_framework_run_test(fwts_framework *fw, fwts_framework_test *test
 
 	/* Not a utility test?, then we require a test summary at end of the test run */
 	if (!(test->flags & FWTS_FLAG_UTILS))
-		fw->print_summary = 1;
+		fw->print_summary = true;
 
 	if (test->ops->description) {
 		fwts_log_heading(fw, "%s", test->ops->description);