Patchwork [2/6] lib: fwts_framework: failed_level should be type fwts_log_level

login
register
mail settings
Submitter Colin King
Date Nov. 21, 2012, 4:24 p.m.
Message ID <1353515085-8053-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/200798/
State Accepted
Headers show

Comments

Colin King - Nov. 21, 2012, 4:24 p.m.
From: Colin Ian King <colin.king@canonical.com>

The failed_level type in the fwts_framework struct should be of
type fwts_log_level rather than an int.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_framework.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Nov. 22, 2012, 6:15 a.m.
On Thu, Nov 22, 2012 at 12:24 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The failed_level type in the fwts_framework struct should be of
> type fwts_log_level rather than an int.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_framework.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index c406faf..693d993 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -118,7 +118,7 @@ typedef struct {
>
>         int minor_test_progress;                /* Percentage completion of current test */
>         int print_summary;                      /* Print summary of results at end of test runs */
> -       int failed_level;                       /* Bit mask of failed levels in test run */
> +       fwts_log_level failed_level;            /* Bit mask of failed levels in test run */
>
>         fwts_list test_taglist;                 /* List of tags found when running all minor tests */
>         fwts_list total_taglist;                /* List of tags found when running all tests */
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Nov. 27, 2012, 2:47 p.m.
On 11/22/2012 12:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The failed_level type in the fwts_framework struct should be of
> type fwts_log_level rather than an int.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/include/fwts_framework.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index c406faf..693d993 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -118,7 +118,7 @@ typedef struct {
>
>   	int minor_test_progress;		/* Percentage completion of current test */
>   	int print_summary;			/* Print summary of results at end of test runs */
> -	int failed_level;			/* Bit mask of failed levels in test run */
> +	fwts_log_level failed_level;		/* Bit mask of failed levels in test run */
>
>   	fwts_list test_taglist;			/* List of tags found when running all minor tests */
>   	fwts_list total_taglist;		/* List of tags found when running all tests */
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
index c406faf..693d993 100644
--- a/src/lib/include/fwts_framework.h
+++ b/src/lib/include/fwts_framework.h
@@ -118,7 +118,7 @@  typedef struct {
 
 	int minor_test_progress;		/* Percentage completion of current test */
 	int print_summary;			/* Print summary of results at end of test runs */
-	int failed_level;			/* Bit mask of failed levels in test run */
+	fwts_log_level failed_level;		/* Bit mask of failed levels in test run */
 
 	fwts_list test_taglist;			/* List of tags found when running all minor tests */
 	fwts_list total_taglist;		/* List of tags found when running all tests */