From patchwork Wed Nov 21 16:24:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 200797 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 4F8C92C00E7 for ; Thu, 22 Nov 2012 03:24:53 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TbD6Z-00059z-Vx; Wed, 21 Nov 2012 16:24:52 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TbD6W-00059V-34 for fwts-devel@lists.ubuntu.com; Wed, 21 Nov 2012 16:24:48 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TbD6W-00021v-0W for fwts-devel@lists.ubuntu.com; Wed, 21 Nov 2012 16:24:48 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 5/6] lib: fwts_framework: use fwts_framework_flags instead of int Date: Wed, 21 Nov 2012 16:24:44 +0000 Message-Id: <1353515085-8053-6-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1353515085-8053-1-git-send-email-colin.king@canonical.com> References: <1353515085-8053-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King We should be using the strongly typed fwts_framework_flags rather than just an int. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- src/lib/include/fwts_framework.h | 4 ++-- src/lib/src/fwts_framework.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h index 0d9e2aa..2f84693 100644 --- a/src/lib/include/fwts_framework.h +++ b/src/lib/include/fwts_framework.h @@ -159,13 +159,13 @@ typedef struct fwts_framework_test { const char *name; fwts_framework_ops *ops; int priority; - int flags; + fwts_framework_flags flags; fwts_results results; /* Per test results */ bool was_run; } fwts_framework_test; int fwts_framework_args(const int argc, char **argv); -void fwts_framework_test_add(const char *name, fwts_framework_ops *ops, const int priority, const int flags); +void fwts_framework_test_add(const char *name, fwts_framework_ops *ops, const int priority, const fwts_framework_flags flags); int fwts_framework_compare_test_name(void *, void *); void fwts_framework_show_version(FILE *fp, const char *name); diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c index c940305..d688edf 100644 --- a/src/lib/src/fwts_framework.c +++ b/src/lib/src/fwts_framework.c @@ -120,7 +120,7 @@ static int fwts_framework_compare_priority(void *data1, void *data2) void fwts_framework_test_add(const char *name, fwts_framework_ops *ops, const int priority, - const int flags) + const fwts_framework_flags flags) { fwts_framework_test *new_test; @@ -221,8 +221,8 @@ static void fwts_framework_show_tests(fwts_framework *fw, bool full) int total = 0; typedef struct { - const char *title; /* Test category */ - const int flag; /* Mask of category */ + const char *title; /* Test category */ + fwts_framework_flags flag; /* Mask of category */ } fwts_categories; static fwts_categories categories[] = {