Patchwork [1/6] lib: fwts_framework: make framework magic id into a uint32_t

login
register
mail settings
Submitter Colin King
Date Nov. 21, 2012, 4:24 p.m.
Message ID <1353515085-8053-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/200796/
State Accepted
Headers show

Comments

Colin King - Nov. 21, 2012, 4:24 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_framework.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Nov. 22, 2012, 6:14 a.m.
On Thu, Nov 22, 2012 at 12:24 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_framework.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 0629c46..c406faf 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -91,7 +91,7 @@ static inline void fwts_framework_summate_results(fwts_results *total, fwts_resu
>   *  Test framework context
>   */
>  typedef struct {
> -       int magic;                              /* identify struct magic */
> +       uint32_t magic;                         /* identify struct magic */
>         fwts_log *results;                      /* log for test results */
>         char *results_logname;                  /* filename of results log */
>
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Nov. 27, 2012, 2:46 p.m.
On 11/22/2012 12:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/include/fwts_framework.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 0629c46..c406faf 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -91,7 +91,7 @@ static inline void fwts_framework_summate_results(fwts_results *total, fwts_resu
>    *  Test framework context
>    */
>   typedef struct {
> -	int magic;				/* identify struct magic */
> +	uint32_t magic;				/* identify struct magic */
>   	fwts_log *results;			/* log for test results */
>   	char *results_logname;			/* filename of results log */
>
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
index 0629c46..c406faf 100644
--- a/src/lib/include/fwts_framework.h
+++ b/src/lib/include/fwts_framework.h
@@ -91,7 +91,7 @@  static inline void fwts_framework_summate_results(fwts_results *total, fwts_resu
  *  Test framework context
  */
 typedef struct {
-	int magic;				/* identify struct magic */
+	uint32_t magic;				/* identify struct magic */
 	fwts_log *results;			/* log for test results */
 	char *results_logname;			/* filename of results log */