Patchwork [3/7] uhci: Fix double unlink

login
register
mail settings
Submitter Gerd Hoffmann
Date Nov. 21, 2012, 2 p.m.
Message ID <1353506404-29446-4-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/200781/
State New
Headers show

Comments

Gerd Hoffmann - Nov. 21, 2012, 2 p.m.
From: Hans de Goede <hdegoede@redhat.com>

uhci_async_cancel() already does a uhci_async_unlink().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/hcd-uhci.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index 078be2a..8e47803 100644
--- a/hw/usb/hcd-uhci.c
+++ b/hw/usb/hcd-uhci.c
@@ -963,7 +963,6 @@  static void uhci_async_complete(USBPort *port, USBPacket *packet)
     UHCIState *s = async->queue->uhci;
 
     if (packet->status == USB_RET_REMOVE_FROM_QUEUE) {
-        uhci_async_unlink(async);
         uhci_async_cancel(async);
         return;
     }