Patchwork [5/7] usb-smartcard-reader: Properly NAK interrupt eps when we've no events

login
register
mail settings
Submitter Gerd Hoffmann
Date Nov. 21, 2012, 2 p.m.
Message ID <1353506404-29446-6-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/200775/
State New
Headers show

Comments

Gerd Hoffmann - Nov. 21, 2012, 2 p.m.
From: Hans de Goede <hdegoede@redhat.com>

When we've no data to return from the interrupt endpoint, return NAK rather
then a 0 length packet.

CC: Alon Levy <alevy@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-smartcard-reader.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 190fcd6..de955b7 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -1002,6 +1002,8 @@  static void ccid_handle_data(USBDevice *dev, USBPacket *p)
                         "handle_data: int_in: notify_slot_change %X, "
                         "requested len %zd\n",
                         s->bmSlotICCState, p->iov.size);
+            } else {
+                p->status = USB_RET_NAK;
             }
             break;
         default: