From patchwork Wed Nov 21 10:12:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [3/5] use int64_t for return values from rbd instead of int From: Stefan Hajnoczi X-Patchwork-Id: 200628 Message-Id: <1353492752-16084-4-git-send-email-stefanha@redhat.com> To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Stefan Priebe Date: Wed, 21 Nov 2012 11:12:30 +0100 From: Stefan Priebe rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. The steps to reproduce are: mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a discard. Important is that you use scsi-hd and set discard_granularity=512. Otherwise rbd disabled discard support. Signed-off-by: Stefan Priebe Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 0aaacaf..f3becc7 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -69,7 +69,7 @@ typedef enum { typedef struct RBDAIOCB { BlockDriverAIOCB common; QEMUBH *bh; - int ret; + int64_t ret; QEMUIOVector *qiov; char *bounce; RBDAIOCmd cmd; @@ -86,7 +86,7 @@ typedef struct RADOSCB { int done; int64_t size; char *buf; - int ret; + int64_t ret; } RADOSCB; #define RBD_FD_READ 0