Patchwork [5/5] ide: Fix status register after short PRDs

login
register
mail settings
Submitter Stefan Hajnoczi
Date Nov. 21, 2012, 10:12 a.m.
Message ID <1353492752-16084-6-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/200626/
State New
Headers show

Comments

Stefan Hajnoczi - Nov. 21, 2012, 10:12 a.m.
From: Kevin Wolf <kwolf@redhat.com>

When failing a request because the length of the regions described by
the PRDT was too short for the requested number of sectors, the IDE
emulation forgot to update the status register, so that the device would
keep the BSY flag set indefinitely.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/ide/core.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/hw/ide/core.c b/hw/ide/core.c
index c2ab787..8da894f 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -625,6 +625,7 @@  void ide_dma_cb(void *opaque, int ret)
     if (s->bus->dma->ops->prepare_buf(s->bus->dma, ide_cmd_is_read(s)) == 0) {
         /* The PRDs were too short. Reset the Active bit, but don't raise an
          * interrupt. */
+        s->status = READY_STAT | SEEK_STAT;
         goto eot;
     }