Patchwork [3/3] xtensa: disable libffi for Xtensa

login
register
mail settings
Submitter Chris Zankel
Date Nov. 20, 2012, 7:01 p.m.
Message ID <50ac8f69.6548420a.6f5c.2a1b@mx.google.com>
Download mbox | patch
Permalink /patch/200603/
State Rejected
Headers show

Comments

Chris Zankel - Nov. 20, 2012, 7:01 p.m.
Xtensa currently doesn't support libffi.

Signed-off-by: Chris Zankel <chris@zankel.net>
---
 package/libffi/Config.in |    1 +
 1 file changed, 1 insertion(+)
Baruch Siach - Nov. 21, 2012, 8:35 a.m.
Hi Chris,

On Tue, Nov 20, 2012 at 11:01:49AM -0800, Chris Zankel wrote:
> Xtensa currently doesn't support libffi.
> 
> Signed-off-by: Chris Zankel <chris@zankel.net>
> ---
>  package/libffi/Config.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libffi/Config.in b/package/libffi/Config.in
> index 7211f8f..4afb669 100644
> --- a/package/libffi/Config.in
> +++ b/package/libffi/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_LIBFFI
>  	bool "libffi"
> +	depends on !BR2_xtensa
>  	help
>  	  The libffi library provides a portable, high level
>  	  programming interface to various calling conventions. This

You need to recursively propagate this 'depends' to all packages selecting 
BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check 
whether a package is actually selectable.

baruch
Chris Zankel - Nov. 21, 2012, 9:36 a.m.
Hi Baruch,

On 11/21/2012 12:35 AM, Baruch Siach wrote:
> Hi Chris,
>
> On Tue, Nov 20, 2012 at 11:01:49AM -0800, Chris Zankel wrote:
>> Xtensa currently doesn't support libffi.
>>
>> Signed-off-by: Chris Zankel <chris@zankel.net>
>> ---
>>  package/libffi/Config.in |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/libffi/Config.in b/package/libffi/Config.in
>> index 7211f8f..4afb669 100644
>> --- a/package/libffi/Config.in
>> +++ b/package/libffi/Config.in
>> @@ -1,5 +1,6 @@
>>  config BR2_PACKAGE_LIBFFI
>>  	bool "libffi"
>> +	depends on !BR2_xtensa
>>  	help
>>  	  The libffi library provides a portable, high level
>>  	  programming interface to various calling conventions. This
> You need to recursively propagate this 'depends' to all packages selecting 
> BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check 
> whether a package is actually selectable.

Ah, good to know. Thanks. Will create another patch.

Cheers!
-Chris
Thomas Petazzoni - Nov. 21, 2012, 10:04 a.m.
Dear Chris Zankel,

On Wed, 21 Nov 2012 01:36:38 -0800, Chris Zankel wrote:

> > You need to recursively propagate this 'depends' to all packages selecting 
> > BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check 
> > whether a package is actually selectable.
> 
> Ah, good to know. Thanks. Will create another patch.

No, don't do it. You will become crazy before you get to the end of it.
libffi is a dependency for glib and python, and glib in turn has a
crazy number of reverse dependencies, themselves having other
reverse dependencies. You would have to add a depends on !BR2_xtensa on
dozens and dozens of packages.

This is a known limitation of kconfig, which we have discussed in
length during the last Buildroot Developer Days, see point 6) in
http://elinux.org/Buildroot:DeveloperDaysELCE2012#Details_of_the_discussion.

For now, I think it's better to just leave libffi as it is, until we
find a good way of solving the entire problem. We know that we should
ignore those autobuilders failures.

Best regards,

Thomas

Patch

diff --git a/package/libffi/Config.in b/package/libffi/Config.in
index 7211f8f..4afb669 100644
--- a/package/libffi/Config.in
+++ b/package/libffi/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on !BR2_xtensa
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This