From patchwork Wed Nov 21 05:51:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 200584 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2094B2C00BE for ; Wed, 21 Nov 2012 16:52:09 +1100 (EST) Received: from localhost ([::1]:56755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb3EF-0000Nx-88 for incoming@patchwork.ozlabs.org; Wed, 21 Nov 2012 00:52:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb3Dn-0000Ev-BQ for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb3Dm-0000Zy-Ch for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb3Dm-0000Zu-5I for qemu-devel@nongnu.org; Wed, 21 Nov 2012 00:51:38 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAL5paND013992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 21 Nov 2012 00:51:36 -0500 Received: from localhost (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAL5pYiL027661; Wed, 21 Nov 2012 00:51:35 -0500 From: Amit Shah To: Anthony Liguori Date: Wed, 21 Nov 2012 11:21:19 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Amit Shah , Paolo Bonzini , qemu list Subject: [Qemu-devel] [PATCH v2 2/4] virtio-rng: remove extra request for entropy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If we got fewer bytes from the backend than requested, don't poke the backend for more bytes; the guest will ask for more (or if the guest has already asked for more, the backend knows about it via handle_input()). Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori --- hw/virtio-rng.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index 6c49bb2..cf5a8ff 100644 --- a/hw/virtio-rng.c +++ b/hw/virtio-rng.c @@ -80,13 +80,6 @@ static void chr_read(void *opaque, const void *buf, size_t size) virtqueue_push(vrng->vq, &elem, len); } virtio_notify(&vrng->vdev, vrng->vq); - - /* - * Lastly, if we had multiple elems queued by the guest, and we - * didn't have enough data to fill them all, indicate we want more - * data. - */ - virtio_rng_process(vrng); } static void virtio_rng_process(VirtIORNG *vrng)