Patchwork [5/6] Phonet: remove useless locking in device cleanup

login
register
mail settings
Submitter Rémi Denis-Courmont
Date Jan. 23, 2009, 1 p.m.
Message ID <1232715630-24951-5-git-send-email-remi.denis-courmont@nokia.com>
Download mbox | patch
Permalink /patch/20043/
State Accepted
Delegated to: David Miller
Headers show

Comments

Rémi Denis-Courmont - Jan. 23, 2009, 1 p.m.
Incoming packets and sockets are already gone.
The netdevice notifier is unregistered under the RTNL lock
There remains a race with the rtnetlink handlers unregistration, but it
is a generic RTNL issue that was already present before this change.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
 net/phonet/pn_dev.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

Patch

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index fd41810..3e24c05 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -204,13 +204,8 @@  void phonet_device_exit(void)
 	struct phonet_device *pnd, *n;
 
 	rtnl_unregister_all(PF_PHONET);
-	rtnl_lock();
-	spin_lock_bh(&pndevs.lock);
+	unregister_netdevice_notifier(&phonet_device_notifier);
 
 	list_for_each_entry_safe(pnd, n, &pndevs.list, list)
 		__phonet_device_free(pnd);
-
-	spin_unlock_bh(&pndevs.lock);
-	rtnl_unlock();
-	unregister_netdevice_notifier(&phonet_device_notifier);
 }