Patchwork toolchain-crosstool-ng: install libthread_db if appropriate

login
register
mail settings
Submitter Richard Braun
Date Nov. 20, 2012, 4:59 p.m.
Message ID <1353430797-26819-1-git-send-email-rbraun@sceen.net>
Download mbox | patch
Permalink /patch/200404/
State Accepted
Commit b644575579cb7f1fddf4f9c38928606e138ac053
Headers show

Comments

Richard Braun - Nov. 20, 2012, 4:59 p.m.
Signed-off-by: Richard Braun <rbraun@sceen.net>
---
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Yann E. MORIN - Nov. 20, 2012, 5:36 p.m.
Richard, All,

On Tuesday 20 November 2012 Richard Braun wrote:
> Signed-off-by: Richard Braun <rbraun@sceen.net>
> ---
>  toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index 5f9119d..ebc7b4b 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -41,6 +41,10 @@ uclibc-source: $(CTNG_DIR)/.config
>  CTNG_LIBS_LIB := ld*.so libc.so libcrypt.so libdl.so libgcc_s.so libm.so    \
>                   libnsl.so libpthread.so libresolv.so librt.so libutil.so
>  
> +ifeq ($(BR2_PACKAGE_GDB_SERVER),y)
> +CTNG_LIBS_LIB += libthread_db.so

Shouldn't that be:
    CTNG_LIBS_USR_LIB += libthread_db.so

Regards,
Yann E. MORIN.
Richard Braun - Nov. 20, 2012, 5:38 p.m.
On Tue, Nov 20, 2012 at 06:36:50PM +0100, Yann E. MORIN wrote:
> > +ifeq ($(BR2_PACKAGE_GDB_SERVER),y)
> > +CTNG_LIBS_LIB += libthread_db.so
> 
> Shouldn't that be:
>     CTNG_LIBS_USR_LIB += libthread_db.so

I don't think so, at least I've always seen libthread_db installed in
/lib, and it does work this way.
Yann E. MORIN - Nov. 20, 2012, 5:42 p.m.
On Tuesday 20 November 2012 Richard Braun wrote:
> Signed-off-by: Richard Braun <rbraun@sceen.net>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index 5f9119d..ebc7b4b 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -41,6 +41,10 @@ uclibc-source: $(CTNG_DIR)/.config
>  CTNG_LIBS_LIB := ld*.so libc.so libcrypt.so libdl.so libgcc_s.so libm.so    \
>                   libnsl.so libpthread.so libresolv.so librt.so libutil.so
>  
> +ifeq ($(BR2_PACKAGE_GDB_SERVER),y)
> +CTNG_LIBS_LIB += libthread_db.so
> +endif
> +
>  #--------------
>  # The libc-specific system libraries (in /lib)
>  # Note: it may be needed to tweak the NSS libs in the glibc and eglibc cases...
> -- 
> 1.7.2.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
>
Peter Korsgaard - Nov. 30, 2012, 9:57 p.m.
>>>>> "Richard" == Richard Braun <rbraun@sceen.net> writes:

 Richard> Signed-off-by: Richard Braun <rbraun@sceen.net>

Committed, thanks.

Patch

diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
index 5f9119d..ebc7b4b 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
@@ -41,6 +41,10 @@  uclibc-source: $(CTNG_DIR)/.config
 CTNG_LIBS_LIB := ld*.so libc.so libcrypt.so libdl.so libgcc_s.so libm.so    \
                  libnsl.so libpthread.so libresolv.so librt.so libutil.so
 
+ifeq ($(BR2_PACKAGE_GDB_SERVER),y)
+CTNG_LIBS_LIB += libthread_db.so
+endif
+
 #--------------
 # The libc-specific system libraries (in /lib)
 # Note: it may be needed to tweak the NSS libs in the glibc and eglibc cases...