From patchwork Tue Nov 20 16:35:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Shawcroft X-Patchwork-Id: 200395 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 167912C0040 for ; Wed, 21 Nov 2012 03:36:04 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354034165; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=rPNPePo XBpQN1U3J1/vdtxifKTc=; b=V/O1mbCEBo18fyBR+orzB+hvFYW6J6Irx0jdtzE 4jHKr37gyztVTBHyLUP9I1kyBBjFjpFoOfI6IvF3jmfXZv3ChWTWD1fWjvpAVOJi tgyQM9TXrkR1cWFerLbAFqUpKW6Ho/ZCRwkQR+Ipimr2nuGk+zwxAM8dpXGZJ3R0 bKP8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=OQkBvXkD+uZ5ZJSzsECXqnn6oMI/2f9iT++Mdnn7rrkSTAptirBQ2gywmbRQj4 IG9xkDhPXyBwqmWFetCPWUOjPvw7Mnug9vc7lksWCXXyav3//QRIhfkR1LF0tt4/ /f+Nyfgz1vwIas/WhNJr0hg3S3OAvblggYN9ZJxpDXvoU=; Received: (qmail 19578 invoked by alias); 20 Nov 2012 16:35:53 -0000 Received: (qmail 19395 invoked by uid 22791); 20 Nov 2012 16:35:50 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Nov 2012 16:35:46 +0000 Received: by mail-la0-f47.google.com with SMTP id u2so4760079lag.20 for ; Tue, 20 Nov 2012 08:35:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.152.105.33 with SMTP id gj1mr15145833lab.49.1353429345336; Tue, 20 Nov 2012 08:35:45 -0800 (PST) Received: by 10.114.13.199 with HTTP; Tue, 20 Nov 2012 08:35:45 -0800 (PST) Date: Tue, 20 Nov 2012 16:35:45 +0000 Message-ID: Subject: [RFC] Parallel build broken on trunk. From: Marcus Shawcroft To: gcc-patches@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Folks, Parallel builds contain a race due to a missing dependency between gengtype-lex.o and $(BCONFIG_H). This was introduced by the commit: http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00926.html .. which injects an include of bconfig.h into the top of gengtype-lex.c but does not make both of the objects built from that file dependent on bconfig.h There is a simple fix, below, but I'm concerned that this is just papering over the cracks, is it really correct that both the build and host machine variants include the same config file? Cheers /Marcus diff --git a/gcc/Makefile.in b/gcc/Makefile.in index d74e7b3..8e8f4d3 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -3885,7 +3885,7 @@ build/gengenrtl.o : gengenrtl.c $(BCONFIG_H) $(SYSTEM_H) rtl.def # the build-%: rule doesn't apply to them. gengtype-lex.o build/gengtype-lex.o : gengtype-lex.c gengtype.h $(SYSTEM_H) -gengtype-lex.o: $(CONFIG_H) +gengtype-lex.o: $(CONFIG_H) $(BCONFIG_H) CFLAGS-gengtype-lex.o += -DGENERATOR_FILE build/gengtype-lex.o: $(BCONFIG_H)