From patchwork Tue Nov 20 14:26:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 200347 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B19E72C00A3 for ; Wed, 21 Nov 2012 01:27:18 +1100 (EST) Received: from localhost ([::1]:34144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaonE-0005Ir-0B for incoming@patchwork.ozlabs.org; Tue, 20 Nov 2012 09:27:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Taomp-0004yd-KL for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:26:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Taoml-0002TP-Ei for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:26:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Taoml-0002T8-7X for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:26:47 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAKEQjTR007075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Nov 2012 09:26:45 -0500 Received: from localhost ([10.65.195.62]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAKEQiO0004351; Tue, 20 Nov 2012 09:26:45 -0500 From: Amit Shah To: Anthony Liguori Date: Tue, 20 Nov 2012 19:56:17 +0530 Message-Id: <4174418d72ef8966c94434a814c2a67d5d33f646.1353421334.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Amit Shah , Paolo Bonzini , qemu list Subject: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Disable the rate-limit timer on device remove (e.g. hot-unplug). Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori --- hw/virtio-rng.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index cf5a8ff..c8a6da7 100644 --- a/hw/virtio-rng.c +++ b/hw/virtio-rng.c @@ -194,6 +194,8 @@ void virtio_rng_exit(VirtIODevice *vdev) { VirtIORNG *vrng = DO_UPCAST(VirtIORNG, vdev, vdev); + qemu_del_timer(vrng->rate_limit_timer); + qemu_free_timer(vrng->rate_limit_timer); unregister_savevm(vrng->qdev, "virtio-rng", vrng); virtio_cleanup(vdev); }