Patchwork [2/4] virtio-rng: remove extra request for entropy

login
register
mail settings
Submitter Amit Shah
Date Nov. 20, 2012, 2:26 p.m.
Message ID <690764e834edc670bfef47b469825b684f5a54f6.1353421334.git.amit.shah@redhat.com>
Download mbox | patch
Permalink /patch/200346/
State New
Headers show

Comments

Amit Shah - Nov. 20, 2012, 2:26 p.m.
If we got fewer bytes from the backend than requested, don't poke the
backend for more bytes; the guest will ask for more (or if the guest has
already asked for more, the backend knows about it via handle_input()).

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 hw/virtio-rng.c | 7 -------
 1 file changed, 7 deletions(-)
Anthony Liguori - Nov. 21, 2012, 1:41 a.m.
Amit Shah <amit.shah@redhat.com> writes:

> If we got fewer bytes from the backend than requested, don't poke the
> backend for more bytes; the guest will ask for more (or if the guest has
> already asked for more, the backend knows about it via handle_input()).
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  hw/virtio-rng.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index 6c49bb2..cf5a8ff 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -80,13 +80,6 @@ static void chr_read(void *opaque, const void *buf, size_t size)
>          virtqueue_push(vrng->vq, &elem, len);
>      }
>      virtio_notify(&vrng->vdev, vrng->vq);
> -
> -    /*
> -     * Lastly, if we had multiple elems queued by the guest, and we
> -     * didn't have enough data to fill them all, indicate we want more
> -     * data.
> -     */
> -    virtio_rng_process(vrng);
>  }
>  
>  static void virtio_rng_process(VirtIORNG *vrng)
> -- 
> 1.8.0

Patch

diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index 6c49bb2..cf5a8ff 100644
--- a/hw/virtio-rng.c
+++ b/hw/virtio-rng.c
@@ -80,13 +80,6 @@  static void chr_read(void *opaque, const void *buf, size_t size)
         virtqueue_push(vrng->vq, &elem, len);
     }
     virtio_notify(&vrng->vdev, vrng->vq);
-
-    /*
-     * Lastly, if we had multiple elems queued by the guest, and we
-     * didn't have enough data to fill them all, indicate we want more
-     * data.
-     */
-    virtio_rng_process(vrng);
 }
 
 static void virtio_rng_process(VirtIORNG *vrng)