Patchwork [2/8] data: klog.json: ACPICA ACPI_ERROR messages, utmath.c

login
register
mail settings
Submitter Colin King
Date Nov. 20, 2012, 11:27 a.m.
Message ID <1353410884-4438-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/200301/
State Accepted
Headers show

Comments

Colin King - Nov. 20, 2012, 11:27 a.m.
From: Colin Ian King <colin.king@canonical.com>

ACPICA ACPI_ERROR messages from utmath.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - Nov. 22, 2012, 6:17 a.m.
On Tue, Nov 20, 2012 at 7:27 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPICA ACPI_ERROR messages from utmath.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index fe4ed2e..ecdbe66 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,9 +80,9 @@
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
> -   "pattern": "Could not acquire AML Interpreter mutex",
> -   "advice": "The ACPI AML interpreter attempted to acquire the mutex but this failed. The interpreter will continue to execute but there will be race conditions occurring.",
> -   "label": "KlogAcpiAmlMutexNotAcquired"
> +   "pattern": "Divide by zero",
> +   "advice": "The ACPI interpreter detected a zero divisor which produce a division by zero error.  The AML code is buggy and this will return an undefined value that may cause unexpected behaviour.",
> +   "label": "KlogAcpiAmlDivideByZero"
>    },
>    {
>     "compare_mode": "string",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Nov. 23, 2012, 9:54 a.m.
On 11/20/2012 07:27 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPICA ACPI_ERROR messages from utmath.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index fe4ed2e..ecdbe66 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,9 +80,9 @@
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> -   "pattern": "Could not acquire AML Interpreter mutex",
> -   "advice": "The ACPI AML interpreter attempted to acquire the mutex but this failed. The interpreter will continue to execute but there will be race conditions occurring.",
> -   "label": "KlogAcpiAmlMutexNotAcquired"
> +   "pattern": "Divide by zero",
> +   "advice": "The ACPI interpreter detected a zero divisor which produce a division by zero error.  The AML code is buggy and this will return an undefined value that may cause unexpected behaviour.",
> +   "label": "KlogAcpiAmlDivideByZero"
>     },
>     {
>      "compare_mode": "string",
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index fe4ed2e..ecdbe66 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -80,9 +80,9 @@ 
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
-   "pattern": "Could not acquire AML Interpreter mutex",
-   "advice": "The ACPI AML interpreter attempted to acquire the mutex but this failed. The interpreter will continue to execute but there will be race conditions occurring.",
-   "label": "KlogAcpiAmlMutexNotAcquired"
+   "pattern": "Divide by zero",
+   "advice": "The ACPI interpreter detected a zero divisor which produce a division by zero error.  The AML code is buggy and this will return an undefined value that may cause unexpected behaviour.",
+   "label": "KlogAcpiAmlDivideByZero"
   },
   {
    "compare_mode": "string",