From patchwork Tue Nov 20 10:53:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 200291 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5D8A32C008F for ; Tue, 20 Nov 2012 22:00:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263Ab2KTLAJ (ORCPT ); Tue, 20 Nov 2012 06:00:09 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:47930 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855Ab2KTLAI (ORCPT ); Tue, 20 Nov 2012 06:00:08 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so4199224pbc.19 for ; Tue, 20 Nov 2012 03:00:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=zIQ5lhVCbwLPQ3mNejN/2dko/TEc+0S2oq8//sdF0jc=; b=ivQ5inYAPIQEOBPKBqwRPulNKeq76GEjcYRu/Kry8OPM4Y9T97SWxoqbYHsgi28N61 EYUwI9HejatdTJttQvk7gUSHznCwqYOd6nnHrmwR73h9+c/oDoEF/3P7qyXcAXp/eUGT /46Un/nDpsGtduJIurdkUWoMtFPr2qOn+id1PMqDzK1oL7hcdYyGZpN7VsOAS3YcQkQc 4ol0N5NpRjfDHQKiMoEIE0UdI97VPEk9S+tCucNmqzGfIcovJ0BDA/ZGkKuoIT54GS3e Qmk6jLVuoXoegjBCxZI9d7f4tDz1hPJVmJweHewZjUp5NT4vJNZVdfv2cHx4vQUTBGpZ xHJw== Received: by 10.68.115.75 with SMTP id jm11mr41676171pbb.28.1353409207759; Tue, 20 Nov 2012 03:00:07 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id gu5sm7908855pbc.10.2012.11.20.03.00.04 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Nov 2012 03:00:07 -0800 (PST) From: Sachin Kamat To: netdev@vger.kernel.org Cc: davem@davemloft.net, sjur.brandeland@stericsson.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] caif: Remove redundant null check before kfree in cfctrl.c Date: Tue, 20 Nov 2012 16:23:58 +0530 Message-Id: <1353408838-28678-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnDcjCKTajvzvnVvproHB1zEuwdJD2JhkCS+iqP3r3P4K/dLO3s9OSobxJ5hBZuP+LL7+EN Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kfree on a null pointer is a no-op. Signed-off-by: Sachin Kamat Acked-by: Sjur Brændeland --- net/caif/cfctrl.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c index 44f270f..a376ec1 100644 --- a/net/caif/cfctrl.c +++ b/net/caif/cfctrl.c @@ -515,8 +515,7 @@ static int cfctrl_recv(struct cflayer *layer, struct cfpkt *pkt) client_layer : NULL); } - if (req != NULL) - kfree(req); + kfree(req); spin_unlock_bh(&cfctrl->info_list_lock); }