From patchwork Tue Nov 20 09:19:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2/2] qxl/verify_surface_cmd: check format != 0 (buggy drivers can do that) Date: Mon, 19 Nov 2012 23:19:01 -0000 From: Alon Levy X-Patchwork-Id: 200270 Message-Id: <1353403141-32070-2-git-send-email-alevy@redhat.com> To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Signed-off-by: Alon Levy --- hw/qxl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index af5f68e..91e4fec 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -455,6 +455,12 @@ static int verify_surface_cmd(PCIQXLDevice *qxl, QXLSurfaceCmd *cmd) return 1; } } + if (cmd->type == QXL_SURFACE_CMD_CREATE && + cmd->u.surface_create.format == 0) { + qxl_set_guest_bug(qxl, "QXL_CMD_SURFACE invalid format: %u\n", + cmd->u.surface_create.format); + return 1; + } return 0; }