| Submitter | Tushar Behera |
|---|---|
| Date | Nov. 20, 2012, 4:31 a.m. |
| Message ID | <1353385912-25882-2-git-send-email-tushar.behera@linaro.org> |
| Download | mbox | patch |
| Permalink | /patch/200260/ |
| State | Accepted |
| Commit | 724c6abf29bcef1aae688f023b7d6dcb7eab0e68 |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
Comments
Patch
diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c index 56b864d..0b580f4 100644 --- a/arch/powerpc/platforms/pseries/pci.c +++ b/arch/powerpc/platforms/pseries/pci.c @@ -40,7 +40,8 @@ void pcibios_name_device(struct pci_dev *dev) */ dn = pci_device_to_OF_node(dev); if (dn) { - const char *loc_code = of_get_property(dn, "ibm,loc-code", 0); + const char *loc_code = of_get_property(dn, "ibm,loc-code", + NULL); if (loc_code) { int loc_len = strlen(loc_code); if (loc_len < sizeof(dev->dev.name)) {
The third argument for of_get_property() is a pointer, hence pass NULL instead of 0. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- This code is in a '#if 0' section, but I went ahead with the patch as this is the only location in kernel where of_get_property is passed 0 as the third argument. If this function is not going to be used again, then we may consider removing the code altogether. arch/powerpc/platforms/pseries/pci.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)