Patchwork [aarch64] add multiarch definitions for aarch64-linux-gnu

login
register
mail settings
Submitter Matthias Klose
Date Nov. 20, 2012, 12:25 a.m.
Message ID <50AACDE3.7000009@ubuntu.com>
Download mbox | patch
Permalink /patch/200220/
State New
Headers show

Comments

Matthias Klose - Nov. 20, 2012, 12:25 a.m.
Am 20.11.2012 00:39, schrieb Joseph S. Myers:
> On Tue, 20 Nov 2012, Matthias Klose wrote:
> 
>> This just adds the multiarch dirname for aarch64. ok for the trunk?  There were
>> macro redefinitions before in aarch64-linux.h (STANDARD_STARTFILE_PREFIX_[12]).
>>  I don't think these are necessary.
> 
> Don't you need to allow for big-endian, and use a different name in that 
> case?

ok. I think for now nobody uses a big-endian configuration, and I'll only define
the multiarch tuple for the little-endian configuration.
Marcus Shawcroft - Nov. 20, 2012, 12:47 p.m.
Thanks Matthias,

> +ARM_EB = $(if $(findstring TARGET_BIG_ENDIAN_DEFAULT=1, $(tm_defines)),eb)
> +ifeq (,$(ARM_EB))
> +MULTIARCH_DIRNAME = $(call if_multiarch,aarch64-linux-gnu)
> +endif

Can we use the name of the architecture, ARM -> AARCH64

Please can we have big endian wired up?

+else
+MULTIARCH_DIRNAME = $(call if_multiarch,aarch64_be-linux-gnu)


Cheers
/Marcus

Patch

Index: aarch64/t-aarch64-linux
===================================================================
--- aarch64/t-aarch64-linux	(revision 193639)
+++ aarch64/t-aarch64-linux	(working copy)
@@ -20,3 +20,8 @@ 

 LIB1ASMSRC   = aarch64/lib1funcs.asm
 LIB1ASMFUNCS = _aarch64_sync_cache_range
+
+ARM_EB = $(if $(findstring TARGET_BIG_ENDIAN_DEFAULT=1, $(tm_defines)),eb)
+ifeq (,$(ARM_EB))
+MULTIARCH_DIRNAME = $(call if_multiarch,aarch64-linux-gnu)
+endif