Patchwork tci: Fix type of tci_read_label

login
register
mail settings
Submitter Richard Henderson
Date Nov. 19, 2012, 8:43 p.m.
Message ID <1353357794-10212-1-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/200153/
State New
Headers show

Comments

Richard Henderson - Nov. 19, 2012, 8:43 p.m.
Fixes the pointer truncation that was occurring for branches.

Cc: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Stefan Weil - Nov. 19, 2012, 9:29 p.m.
Am 19.11.2012 21:43, schrieb Richard Henderson:
> Fixes the pointer truncation that was occurring for branches.
>
> Cc: Stefan Weil<sw@weilnetz.de>
> Cc: Blue Swirl<blauwirbel@gmail.com>
> Signed-off-by: Richard Henderson<rth@twiddle.net>
> ---
>   tci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tci.c b/tci.c
> index 9c87c8e..54cf1d9 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -338,9 +338,9 @@ static uint64_t tci_read_ri64(uint8_t **tb_ptr)
>   }
>   #endif
>
> -static target_ulong tci_read_label(uint8_t **tb_ptr)
> +static tcg_target_ulong tci_read_label(uint8_t **tb_ptr)
>   {
> -    target_ulong label = tci_read_i(tb_ptr);
> +    tcg_target_ulong label = tci_read_i(tb_ptr);
>       assert(label != 0);
>       return label;
>   }
>    

Thanks for fixing this.

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Tested-by: Stefan Weil <sw@weilnetz.de>
Blue Swirl - Nov. 24, 2012, 9 p.m.
Thanks, applied.

On Mon, Nov 19, 2012 at 8:43 PM, Richard Henderson <rth@twiddle.net> wrote:
> Fixes the pointer truncation that was occurring for branches.
>
> Cc: Stefan Weil <sw@weilnetz.de>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tci.c b/tci.c
> index 9c87c8e..54cf1d9 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -338,9 +338,9 @@ static uint64_t tci_read_ri64(uint8_t **tb_ptr)
>  }
>  #endif
>
> -static target_ulong tci_read_label(uint8_t **tb_ptr)
> +static tcg_target_ulong tci_read_label(uint8_t **tb_ptr)
>  {
> -    target_ulong label = tci_read_i(tb_ptr);
> +    tcg_target_ulong label = tci_read_i(tb_ptr);
>      assert(label != 0);
>      return label;
>  }
> --
> 1.7.11.7
>

Patch

diff --git a/tci.c b/tci.c
index 9c87c8e..54cf1d9 100644
--- a/tci.c
+++ b/tci.c
@@ -338,9 +338,9 @@  static uint64_t tci_read_ri64(uint8_t **tb_ptr)
 }
 #endif
 
-static target_ulong tci_read_label(uint8_t **tb_ptr)
+static tcg_target_ulong tci_read_label(uint8_t **tb_ptr)
 {
-    target_ulong label = tci_read_i(tb_ptr);
+    tcg_target_ulong label = tci_read_i(tb_ptr);
     assert(label != 0);
     return label;
 }