Patchwork block: add bdrv_reopen() support for raw hdev devices

login
register
mail settings
Submitter Jeff Cody
Date Nov. 19, 2012, 3:37 p.m.
Message ID <9cdf58cc9d0e9476a0d549176f14e6f40bbb7d51.1353339221.git.jcody@redhat.com>
Download mbox | patch
Permalink /patch/200036/
State New
Headers show

Comments

Jeff Cody - Nov. 19, 2012, 3:37 p.m.
The host device reopen handler for raw-posix is the same as the file reopen
handler.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/raw-posix.c | 3 +++
 1 file changed, 3 insertions(+)
Kevin Wolf - Nov. 19, 2012, 3:45 p.m.
Am 19.11.2012 16:37, schrieb Jeff Cody:
> The host device reopen handler for raw-posix is the same as the file reopen
> handler.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/raw-posix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index f2f0404..c7061e6 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1409,6 +1409,9 @@ static BlockDriver bdrv_host_device = {
>      .bdrv_probe_device  = hdev_probe_device,
>      .bdrv_file_open     = hdev_open,
>      .bdrv_close         = raw_close,
> +    .bdrv_reopen_prepare = raw_reopen_prepare,
> +    .bdrv_reopen_commit  = raw_reopen_commit,
> +    .bdrv_reopen_abort   = raw_reopen_abort,
>      .bdrv_create        = hdev_create,
>      .create_options     = raw_create_options,
>      .bdrv_has_zero_init = hdev_has_zero_init,
> 

What about host_floppy and (twice) host_cdrom?

Kevin
Jeff Cody - Nov. 19, 2012, 4:16 p.m.
On 11/19/2012 10:45 AM, Kevin Wolf wrote:
> Am 19.11.2012 16:37, schrieb Jeff Cody:
>> The host device reopen handler for raw-posix is the same as the file reopen
>> handler.
>>

> 
> What about host_floppy and (twice) host_cdrom?
> 
> Kevin
> 

Do we need / want reopen for floppy and/or cdrom?
Kevin Wolf - Nov. 19, 2012, 4:19 p.m.
Am 19.11.2012 17:16, schrieb Jeff Cody:
> On 11/19/2012 10:45 AM, Kevin Wolf wrote:
>> Am 19.11.2012 16:37, schrieb Jeff Cody:
>>> The host device reopen handler for raw-posix is the same as the file reopen
>>> handler.
>>>
> 
>>
>> What about host_floppy and (twice) host_cdrom?
>>
>> Kevin
>>
> 
> Do we need / want reopen for floppy and/or cdrom?

At least I can't see what makes it less reasonable than for host_device.
They are really just host_device with one or two additional callbacks
for handling removable media.

Kevin

Patch

diff --git a/block/raw-posix.c b/block/raw-posix.c
index f2f0404..c7061e6 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1409,6 +1409,9 @@  static BlockDriver bdrv_host_device = {
     .bdrv_probe_device  = hdev_probe_device,
     .bdrv_file_open     = hdev_open,
     .bdrv_close         = raw_close,
+    .bdrv_reopen_prepare = raw_reopen_prepare,
+    .bdrv_reopen_commit  = raw_reopen_commit,
+    .bdrv_reopen_abort   = raw_reopen_abort,
     .bdrv_create        = hdev_create,
     .create_options     = raw_create_options,
     .bdrv_has_zero_init = hdev_has_zero_init,