From patchwork Mon Nov 19 14:14:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] slirp: Don't crash on packets from 0.0.0.0/8. From: Jan Kiszka X-Patchwork-Id: 200015 Message-Id: <1a89b60885ccc2abf7cc50275fcee70d0347425e.1353334465.git.jan.kiszka@siemens.com> To: Anthony Liguori , qemu-devel Cc: Nickolai Zeldovich Date: Mon, 19 Nov 2012 15:14:31 +0100 From: Nickolai Zeldovich LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich Signed-off-by: Jan Kiszka --- slirp/arp_table.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/slirp/arp_table.c b/slirp/arp_table.c index 5d7b8ac..bf698c1 100644 --- a/slirp/arp_table.c +++ b/slirp/arp_table.c @@ -38,7 +38,9 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN]) ethaddr[3], ethaddr[4], ethaddr[5])); /* Check 0.0.0.0/8 invalid source-only addresses */ - assert((ip_addr & htonl(~(0xf << 28))) != 0); + if ((ip_addr & htonl(~(0xf << 28))) == 0) { + return; + } if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) { /* Do not register broadcast addresses */