[3/6] claw: remove BUG_ONs

Submitter	frank.blaschka@de.ibm.com
Date	Nov. 19, 2012, 12:46 p.m.
Message ID	<20121119124659.615539931@de.ibm.com>
Download	mbox \| patch
Permalink	/patch/200001/
State	Accepted
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> Gateway: Authorized Use Only! Violators will be prosecuted for <netdev@vger.kernel.org> from <frank.blaschka@de.ibm.com>; Mon, 19 Nov 2012 12:47:02 -0000 Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Nov 2012 12:47:00 -0000 Message-Id: <20121119124659.615539931@de.ibm.com> User-Agent: quilt/0.47-1 Date: Mon, 19 Nov 2012 13:46:47 +0100 From: frank.blaschka@de.ibm.com To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, Ursula Braun <ursula.braun@de.ibm.com> Subject: [patch 3/6] [PATCH] claw: remove BUG_ONs References: <20121119124644.679089322@de.ibm.com> Content-Disposition: inline; filename=605-claw-bugon.diff Sender: netdev-owner@vger.kernel.org Precedence: bulk

Comments

frank.blaschka@de.ibm.com - Nov. 19, 2012, 12:46 p.m.

From: Ursula Braun <ursula.braun@de.ibm.com>

Remove BUG_ON's in claw driver, since the checked error conditions
are null pointer accesses.

Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
 drivers/s390/net/claw.c |    2 --
 1 file changed, 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -3018,10 +3018,8 @@  claw_remove_device(struct ccwgroup_devic
 {
 	struct claw_privbk *priv;
 
-	BUG_ON(!cgdev);
 	CLAW_DBF_TEXT_(2, setup, "%s", dev_name(&cgdev->dev));
 	priv = dev_get_drvdata(&cgdev->dev);
-	BUG_ON(!priv);
 	dev_info(&cgdev->dev, " will be removed.\n");
 	if (cgdev->state == CCWGROUP_ONLINE)
 		claw_shutdown_device(cgdev);

Patchwork [3/6] claw: remove BUG_ONs

Comments

Patch