Patchwork [1,of,2] Remove sstrip (obsolete)

login
register
mail settings
Submitter Yann Diorcet
Date Nov. 19, 2012, 10:22 a.m.
Message ID <65c8bf534d0647ce52cd.1353320545@macbook-smorlat.local>
Download mbox | patch
Permalink /patch/199970/
State Accepted
Commit 2b64e1b502cd
Headers show

Comments

Yann Diorcet - Nov. 19, 2012, 10:22 a.m.
# HG changeset patch
# User Yann Diorcet (diorcet.yann@gmail.com)
# Date 1353320394 -3600
# Node ID 65c8bf534d0647ce52cdb319b52dab2f81da5017
# Parent  d24043276c9243a35421763b192f4cf59cea650b
Remove sstrip (obsolete)

config: Remove sstrip in binutils
script: Remove sstrip script

Signed-off-by: Yann Diorcet <diorcet.yann@gmail.com>


--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - Nov. 19, 2012, 6:23 p.m.
Yann, All,

On Monday 19 November 2012 Yann Diorcet wrote:
> # HG changeset patch
> # User Yann Diorcet (diorcet.yann@gmail.com)

Again, those parenthesis, when you should use < and >.
I fixed it locally. Please be update your ~/.hgrc

> # Date 1353320394 -3600
> # Node ID 65c8bf534d0647ce52cdb319b52dab2f81da5017
> # Parent  d24043276c9243a35421763b192f4cf59cea650b
> Remove sstrip (obsolete)

I've also re-phrased the commit message. Please look at:
    docs/7 - Contributing to crosstool-NG.txt
    docs/C - Misc. tutorials.txt
for how to format the commit messages.

Otherwise, OK. I've applied it locally, will push it later tonight.
Thank you!

Regards,
Yann E. MORIN.
Yann E. MORIN - Nov. 19, 2012, 9:28 p.m.
Yann, All,

Your patch:
    binutils/sstrip: remove

has been applied as: #2b64e1b502cd
    http://crosstool-ng.org/hg/crosstool-ng/rev/2b64e1b502cd

Thank you!

Regards,
Yann E. MORIN.



--
For unsubscribe information see http://sourceware.org/lists.html#faq

Patch

diff -r d24043276c92 -r 65c8bf534d06 config/binutils.in
--- a/config/binutils.in	Fri Nov 16 15:25:57 2012 +0100
+++ b/config/binutils.in	Mon Nov 19 11:19:54 2012 +0100
@@ -40,6 +40,5 @@ 
 
 source "config/binutils/binutils.in"
 source "config/binutils/elf2flt.in"
-source "config/binutils/sstrip.in"
 
 endmenu
diff -r d24043276c92 -r 65c8bf534d06 config/binutils/sstrip.in
--- a/config/binutils/sstrip.in	Fri Nov 16 15:25:57 2012 +0100
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,23 +0,0 @@ 
-# Configuration file for sstrip tool facility
-
-if OBSOLETE && ! BACKEND && ARCH_BINFMT_ELF
-
-comment "sstrip"
-
-config SSTRIP
-    bool
-    prompt "sstrip (OBSOLETE)"
-    help
-      The sstrip utility, to maximise the striping of ELF binaries
-      (executables and libraries).
-      
-      Buildroot version, forked off the original from ELFkickers.
-      This one is somewhat maintained by the buildroot guys.
-      Supports big-endian systems.
-      
-      NOTE! Please read.
-        sstrip is now deprecated in crosstool-NG, as it has a few
-        shortcomings. For example: it breaks for PPC targets, it
-        does not build on non-ELF hosts (eg. mingw32, MacOS-X...).
-
-endif
diff -r d24043276c92 -r 65c8bf534d06 scripts/build/binutils/sstrip.sh
--- a/scripts/build/binutils/sstrip.sh	Fri Nov 16 15:25:57 2012 +0100
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,43 +0,0 @@ 
-# This will build and install sstrip to run on host and sstrip target files
-
-do_sstrip_get()      { :; }
-do_sstrip_extract()  { :; }
-do_sstrip_for_host() { :; }
-
-if [ "${CT_SSTRIP}" = "y" ]; then
-    do_sstrip_get() {
-        CT_GetFile sstrip .c http://git.buildroot.net/buildroot/plain/toolchain/sstrip
-    }
-
-    do_sstrip_extract() {
-        # We leave the sstrip maintenance to the buildroot people:
-        # -> any fix-up goes directly there
-        # -> we don't have patches for it
-        # -> we don't need to patch it
-        # -> just create a directory in src/, and copy it there.
-        CT_DoExecLog DEBUG mkdir -p "${CT_SRC_DIR}/sstrip"
-        CT_DoExecLog DEBUG cp -v "${CT_TARBALLS_DIR}/sstrip.c" "${CT_SRC_DIR}/sstrip"
-    }
-
-    # Build sstrip for host -> target
-    # Note: we don't need sstrip to run on the build machine,
-    # so we do not need the frontend/backend stuff...
-    do_sstrip_for_host() {
-        local sstrip_cflags
-        CT_DoStep INFO "Installing sstrip for host"
-        CT_mkdir_pushd "${CT_BUILD_DIR}/build-sstrip-host"
-
-        if [ "${CT_STATIC_TOOLCHAIN}" = "y" ]; then
-            sstrip_cflags="-static"
-        fi
-
-        CT_DoLog EXTRA "Building sstrip"
-        CT_DoExecLog ALL "${CT_HOST}-gcc" -Wall ${sstrip_cflags} -o sstrip "${CT_SRC_DIR}/sstrip/sstrip.c"
-
-        CT_DoLog EXTRA "Installing sstrip"
-        CT_DoExecLog ALL install -m 755 sstrip "${CT_PREFIX_DIR}/bin/${CT_TARGET}-sstrip"
-
-        CT_Popd
-        CT_EndStep
-    }
-fi
diff -r d24043276c92 -r 65c8bf534d06 scripts/crosstool-NG.sh.in
--- a/scripts/crosstool-NG.sh.in	Fri Nov 16 15:25:57 2012 +0100
+++ b/scripts/crosstool-NG.sh.in	Mon Nov 19 11:19:54 2012 +0100
@@ -129,7 +129,6 @@ 
 . "${CT_LIB_DIR}/scripts/build/companion_libs.sh"
 . "${CT_LIB_DIR}/scripts/build/binutils/binutils.sh"
 . "${CT_LIB_DIR}/scripts/build/binutils/elf2flt.sh"
-. "${CT_LIB_DIR}/scripts/build/binutils/sstrip.sh"
 . "${CT_LIB_DIR}/scripts/build/libc/${CT_LIBC}.sh"
 . "${CT_LIB_DIR}/scripts/build/cc/${CT_CC}.sh"
 . "${CT_LIB_DIR}/scripts/build/debug.sh"
@@ -547,7 +546,6 @@ 
     do_companion_libs_get
     do_binutils_get
     do_elf2flt_get
-    do_sstrip_get
     do_cc_get
     do_libc_get
     do_debug_get
@@ -572,7 +570,6 @@ 
         do_companion_libs_extract
         do_binutils_extract
         do_elf2flt_extract
-        do_sstrip_extract
         do_cc_extract
         do_libc_extract
         do_debug_extract
diff -r d24043276c92 -r 65c8bf534d06 steps.mk
--- a/steps.mk	Fri Nov 16 15:25:57 2012 +0100
+++ b/steps.mk	Mon Nov 19 11:19:54 2012 +0100
@@ -25,7 +25,6 @@ 
             companion_libs_for_host  \
             binutils_for_host        \
             elf2flt_for_host         \
-            sstrip_for_host          \
             cc_core_pass_1           \
             kernel_headers           \
             libc_start_files         \