Patchwork use configured install command

login
register
mail settings
Submitter Martin Nowak
Date Nov. 19, 2012, 9:58 a.m.
Message ID <50AA02BD.5070908@dawgfoto.de>
Download mbox | patch
Permalink /patch/199964/
State Changes Requested
Headers show

Comments

Martin Nowak - Nov. 19, 2012, 9:58 a.m.
# HG changeset patch
# User Martin Nowak <dawg@dawgfoto.de>
# Date 1353317648 -3600
# Node ID d1e251600fe44813e5e531ed079ca23dda546061
# Parent  f7a40ba0b651197c0d0bceb5a4aecdce77243a18
use configured install command

          done

  install-doc: $(DESTDIR)$(docdir)


--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - Nov. 19, 2012, 6:06 p.m.
Martin, All,

On Monday 19 November 2012 Martin Nowak wrote:
> # HG changeset patch
> # User Martin Nowak <dawg@dawgfoto.de>
> # Date 1353317648 -3600
> # Node ID d1e251600fe44813e5e531ed079ca23dda546061
> # Parent  f7a40ba0b651197c0d0bceb5a4aecdce77243a18
> use configured install command

Good catch. However, there are a few issues with your patch:
  - it's been line-wrapped in-transit, see below; use 'hg email' to
    send your patches, it ensures they arrive un-broken;
  - you must include your Signed-off-by line. See:
        docs/7 - Contributing to crosstool-NG.txt

> diff -r f7a40ba0b651 -r d1e251600fe4 Makefile.in
> --- a/Makefile.in       Tue Nov 06 17:42:39 2012 +0100
> +++ b/Makefile.in       Mon Nov 19 10:34:08 2012 +0100
> @@ -349,7 +349,7 @@
>          @echo "  INST    'kconfig/'"
>          @mkdir -p "$(DESTDIR)$(libdir)/kconfig"
>          @for f in $(KCONFIG_FILES); 
> do                                      \
> -           install "kconfig/$${f}" 
> "$(DESTDIR)$(libdir)/kconfig/$${f}";    \
> +           $(install) "kconfig/$${f}" 
> "$(DESTDIR)$(libdir)/kconfig/$${f}"; \
>           done
> 
>   install-doc: $(DESTDIR)$(docdir)

Regards,
Yann E. MORIN.

Patch

diff -r f7a40ba0b651 -r d1e251600fe4 Makefile.in
--- a/Makefile.in       Tue Nov 06 17:42:39 2012 +0100
+++ b/Makefile.in       Mon Nov 19 10:34:08 2012 +0100
@@ -349,7 +349,7 @@ 
         @echo "  INST    'kconfig/'"
         @mkdir -p "$(DESTDIR)$(libdir)/kconfig"
         @for f in $(KCONFIG_FILES); 
do                                      \
-           install "kconfig/$${f}" 
"$(DESTDIR)$(libdir)/kconfig/$${f}";    \
+           $(install) "kconfig/$${f}" 
"$(DESTDIR)$(libdir)/kconfig/$${f}"; \