Patchwork Fix the inconsistency in x509-dh-key-file parameter

login
register
mail settings
Submitter Lei Li
Date Nov. 19, 2012, 9:15 a.m.
Message ID <1353316508-16816-1-git-send-email-lilei@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/199957/
State New
Headers show

Comments

Lei Li - Nov. 19, 2012, 9:15 a.m.
Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls
support) added options to the -spice command line. But there
is an inconsistency between the declaration of the option
'x509-dh-key-file' to -spice command line and its parameter
parsing 'x509-dh-file' in function qemu_spice_init.

https://bugs.launchpad.net/qemu/+bug/1035042

Reported-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
 ui/spice-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Gerd Hoffmann - Nov. 19, 2012, 9:59 a.m.
On 11/19/12 10:15, Lei Li wrote:
> Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls
> support) added options to the -spice command line. But there
> is an inconsistency between the declaration of the option
> 'x509-dh-key-file' to -spice command line and its parameter
> parsing 'x509-dh-file' in function qemu_spice_init.

Patch added to spice patch queue.

thanks,
  Gerd

Patch

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 5147365..261c6f2 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -610,7 +610,7 @@  void qemu_spice_init(void)
         }
 
         x509_key_password = qemu_opt_get(opts, "x509-key-password");
-        x509_dh_file = qemu_opt_get(opts, "x509-dh-file");
+        x509_dh_file = qemu_opt_get(opts, "x509-dh-key-file");
         tls_ciphers = qemu_opt_get(opts, "tls-ciphers");
     }