Patchwork arm: a9mpcore: remove un-used ptimer_iomem field

login
register
mail settings
Submitter Peter Crosthwaite
Date Nov. 19, 2012, 5:13 a.m.
Message ID <1353302029-14255-1-git-send-email-peter.crosthwaite@xilinx.com>
Download mbox | patch
Permalink /patch/199925/
State New
Headers show

Comments

Peter Crosthwaite - Nov. 19, 2012, 5:13 a.m.
I'm guessing this is a hangover from a previous coreification of the mptimer
sub-module. This field is completely unused - removed.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
 hw/a9mpcore.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Peter Maydell - Nov. 19, 2012, 8:31 a.m.
On 19 November 2012 05:13, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> I'm guessing this is a hangover from a previous coreification of the mptimer
> sub-module. This field is completely unused - removed.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM
Stefan Hajnoczi - Dec. 3, 2012, 12:52 p.m.
On Mon, Nov 19, 2012 at 03:13:49PM +1000, Peter Crosthwaite wrote:
> I'm guessing this is a hangover from a previous coreification of the mptimer
> sub-module. This field is completely unused - removed.
> 
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>  hw/a9mpcore.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c
index 824ff0a..f802de0 100644
--- a/hw/a9mpcore.c
+++ b/hw/a9mpcore.c
@@ -19,7 +19,6 @@  typedef struct a9mp_priv_state {
     uint32_t old_timer_status[8];
     uint32_t num_cpu;
     MemoryRegion scu_iomem;
-    MemoryRegion ptimer_iomem;
     MemoryRegion container;
     DeviceState *mptimer;
     DeviceState *gic;