From patchwork Sun Nov 18 10:24:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 199899 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0450D2C0081 for ; Sun, 18 Nov 2012 21:27:44 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353839265; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Cc:Subject:Date:Message-ID:User-Agent: In-Reply-To:References:MIME-Version:Content-Type: Content-Transfer-Encoding:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=snO3Duu0Lo+2dT2OEN4Utf6CIEQ=; b=ch1LU5xftTmQqzK spxojFZO+Bw/sSKvR3DeUh8cFzy508ssDVz0eioBeQHsBS+E4fgOdJpAI+ylD4sn 5b4N/Iz50nNCMfpBLxWCq082sNazr/NrkO6KbDyaN3obuZ1lxjkq56DcG/azhumc ViE7dkZr4YiF5j3Hv9oFj7LiqXjQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=cmIo9dk9qlil2H0w03ld4hQjwLRWrYs3f27V1+d2JY1sxHCEOS+Zpm008NKEd2 CN7w+yPoB6Ne21ol83gPJcrbd6QwTU+djvgXwXTLMht4C/fLHdRMQo7foUZSmyGr PsP5Ai4169B713wSwTEqbGkiS8xqMp3Ord0HpBmywwUp0=; Received: (qmail 673 invoked by alias); 18 Nov 2012 10:27:38 -0000 Received: (qmail 665 invoked by uid 22791); 18 Nov 2012 10:27:37 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, TW_TM X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 18 Nov 2012 10:27:29 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id B0A20CB16F5; Sun, 18 Nov 2012 11:27:31 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uCAvzdBPee-9; Sun, 18 Nov 2012 11:27:31 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 76088CB0D0E; Sun, 18 Nov 2012 11:27:31 +0100 (CET) From: Eric Botcazou To: Diego Novillo Cc: gcc-patches@gcc.gnu.org Subject: Re: VEC re-write [patch 04/25] Date: Sun, 18 Nov 2012 11:24:06 +0100 Message-ID: <3661744.pNhyNtmbkC@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.16-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <20121115215329.04E2EC0916@torture.tor.corp.google.com> References: <20121115215329.04E2EC0916@torture.tor.corp.google.com> MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > 2012-11-15 Diego Novillo > > Adjust for new vec API (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec) > > * gcc-interface/decl.c: Use new vec API in vec.h. > * gcc-interface/gigi.h: Likewise. > * gcc-interface/trans.c: Likewise. > * gcc-interface/utils.c: Likewise. > * gcc-interface/utils2.c: Likewise. Thanks for the great work, everything seems to be working fine in Ada. Minor nit: the patch has introduced a couple of trailing spaces. No big deal, but we have a script that rejects the changes in this case. Fixed thusly. 2012-11-18 Eric Botcazou * gcc-interface/decl.c: Remove trailing spaces. * gcc-interface/trans.c: Remove trailing spaces. Index: gcc-interface/decl.c =================================================================== --- gcc-interface/decl.c (revision 193596) +++ gcc-interface/decl.c (working copy) @@ -7549,7 +7549,7 @@ build_position_list (tree gnu_type, bool of operands to SUBSTITUTE_IN_EXPR. DEFINITION is true if this is for a definition of GNAT_SUBTYPE. */ -static vec +static vec build_subst_list (Entity_Id gnat_subtype, Entity_Id gnat_type, bool definition) { vec gnu_list = vec(); @@ -7582,7 +7582,7 @@ build_subst_list (Entity_Id gnat_subtype the substitutions described in SUBST_LIST. GNU_LIST is a pre-existing list to be prepended to the newly created entries. */ -static vec +static vec build_variant_list (tree qual_union_type, vec subst_list, vec gnu_list) { Index: gcc-interface/trans.c =================================================================== --- gcc-interface/trans.c (revision 193596) +++ gcc-interface/trans.c (working copy) @@ -3323,7 +3323,7 @@ Subprogram_Body_to_gnu (Node_Id gnat_nod { tree gnu_return_var = NULL_TREE; - vec_safe_push (gnu_return_label_stack, + vec_safe_push (gnu_return_label_stack, create_artificial_label (input_location)); start_stmt_group (); @@ -4385,7 +4385,7 @@ Handled_Sequence_Of_Statements_to_gnu (N start_stmt_group (); gnat_pushlevel (); - vec_safe_push (gnu_except_ptr_stack, + vec_safe_push (gnu_except_ptr_stack, create_var_decl (get_identifier ("EXCEPT_PTR"), NULL_TREE, build_pointer_type (except_type_node), build_call_n_expr (get_excptr_decl, 0),