From patchwork Sun Nov 18 08:26:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: block: Fix regression for MinGW (assertion caused by short string) Date: Sat, 17 Nov 2012 22:26:15 -0000 From: Stefan Weil X-Patchwork-Id: 199898 Message-Id: <1353227175-24596-1-git-send-email-sw@weilnetz.de> To: qemu-trivial@nongnu.org Cc: Kevin Wolf , Jim Meyering , qemu-devel@nongnu.org, Stefan Weil The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this regression. Signed-off-by: Stefan Weil --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 49dd6bb..8739635 100644 --- a/block.c +++ b/block.c @@ -787,7 +787,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *drv) { int ret; - char tmp_filename[PATH_MAX]; + char tmp_filename[PATH_MAX + 1]; if (flags & BDRV_O_SNAPSHOT) { BlockDriverState *bs1;