From patchwork Sat Nov 17 11:17:37 2012
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [v2] checkpatch: add double empty line check
Date: Sat, 17 Nov 2012 01:17:37 -0000
From: Eilon Greenstein <eilong@broadcom.com>
X-Patchwork-Id: 199834
Message-Id: <1353151057.14327.18.camel@lb-tlvb-eilong.il.broadcom.com>
To: "Andy Whitcroft" <apw@canonical.com>
Cc: "Joe Perches" <joe@perches.com>, "David Rientjes" <rientjes@google.com>,
 linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>

Changes from previous attempt:
- Use CHK instead of WARN
- Issue only one warning per empty lines block

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>

---
scripts/checkpatch.pl |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 21a9f5d..13d264f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3579,6 +3579,14 @@ sub process {
 			WARN("EXPORTED_WORLD_WRITABLE",
 			     "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
 		}
+
+# check for double empty lines
+		if ($line =~ /^\+\s*$/ &&
+		    ($rawlines[$linenr] =~ /^\s*$/ ||
+		     $prevline =~ /^\+?\s*$/ && $rawlines[$linenr] !~ /^\+\s*$/)) {
+			CHK("DOUBLE_EMPTY_LINE",
+			    "One empty line should be sufficient. Consider removing this one.\n" . $herecurr);
+		}
 	}
 
 	# If we have no input at all, then there is nothing to report on