| Message ID | 1353134389-25583-1-git-send-email-akinobu.mita@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 11/17/2012 01:39 AM, Akinobu Mita wrote: > Use bitmap_weight to count the total number of bits set in bitmap. > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Vlad Yasevich <vyasevich@gmail.com> > Cc: Sridhar Samudrala <sri@us.ibm.com> > Cc: linux-sctp@vger.kernel.org > Cc: netdev@vger.kernel.org Acked-by: Vlad Yasevich <vyasevich@gmail.com> -vlad > --- > net/sctp/tsnmap.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/net/sctp/tsnmap.c b/net/sctp/tsnmap.c > index b5fb7c4..5f25e0c 100644 > --- a/net/sctp/tsnmap.c > +++ b/net/sctp/tsnmap.c > @@ -272,7 +272,7 @@ __u16 sctp_tsnmap_pending(struct sctp_tsnmap *map) > __u32 max_tsn = map->max_tsn_seen; > __u32 base_tsn = map->base_tsn; > __u16 pending_data; > - u32 gap, i; > + u32 gap; > > pending_data = max_tsn - cum_tsn; > gap = max_tsn - base_tsn; > @@ -280,11 +280,7 @@ __u16 sctp_tsnmap_pending(struct sctp_tsnmap *map) > if (gap == 0 || gap >= map->len) > goto out; > > - for (i = 0; i < gap+1; i++) { > - if (test_bit(i, map->tsn_map)) > - pending_data--; > - } > - > + pending_data -= bitmap_weight(map->tsn_map, gap + 1); > out: > return pending_data; > } > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Vlad Yasevich <vyasevich@gmail.com> Date: Sat, 17 Nov 2012 20:45:19 -0500 > On 11/17/2012 01:39 AM, Akinobu Mita wrote: >> Use bitmap_weight to count the total number of bits set in bitmap. >> >> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> >> Cc: Vlad Yasevich <vyasevich@gmail.com> >> Cc: Sridhar Samudrala <sri@us.ibm.com> >> Cc: linux-sctp@vger.kernel.org >> Cc: netdev@vger.kernel.org > > Acked-by: Vlad Yasevich <vyasevich@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/tsnmap.c b/net/sctp/tsnmap.c index b5fb7c4..5f25e0c 100644 --- a/net/sctp/tsnmap.c +++ b/net/sctp/tsnmap.c @@ -272,7 +272,7 @@ __u16 sctp_tsnmap_pending(struct sctp_tsnmap *map) __u32 max_tsn = map->max_tsn_seen; __u32 base_tsn = map->base_tsn; __u16 pending_data; - u32 gap, i; + u32 gap; pending_data = max_tsn - cum_tsn; gap = max_tsn - base_tsn; @@ -280,11 +280,7 @@ __u16 sctp_tsnmap_pending(struct sctp_tsnmap *map) if (gap == 0 || gap >= map->len) goto out; - for (i = 0; i < gap+1; i++) { - if (test_bit(i, map->tsn_map)) - pending_data--; - } - + pending_data -= bitmap_weight(map->tsn_map, gap + 1); out: return pending_data; }
Use bitmap_weight to count the total number of bits set in bitmap. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Vlad Yasevich <vyasevich@gmail.com> Cc: Sridhar Samudrala <sri@us.ibm.com> Cc: linux-sctp@vger.kernel.org Cc: netdev@vger.kernel.org --- net/sctp/tsnmap.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)