Patchwork Patch: add AM_MAINTAINER_MODE in libsanitizer

login
register
mail settings
Submitter Tom Tromey
Date Nov. 16, 2012, 2:57 p.m.
Message ID <87pq3dvbm0.fsf@fleche.redhat.com>
Download mbox | patch
Permalink /patch/199647/
State New
Headers show

Comments

Tom Tromey - Nov. 16, 2012, 2:57 p.m.
My build of gcc today tried to run autoconf in libsanitizer.
However, I had the wrong version in my path, so the build died.

In gcc it is normal to use AM_MAINTAINER_MODE to avoid this problem.
I think this is missing from libsanitizer/configure.ac due to an
oversight.

This patch adds the missing call.

Ok?

Tom

2012-11-16  Tom Tromey  <tromey@redhat.com>

	* configure.ac: Invoke AM_MAINTAINER_MODE.
	* aclocal.m4, configure, Makefile.in, asan/Makefile.in,
	interception/Makefile.in, sanitizer_common/Makefile.in: Rebuild.
Jakub Jelinek - Nov. 16, 2012, 3 p.m.
On Fri, Nov 16, 2012 at 07:57:59AM -0700, Tom Tromey wrote:
> My build of gcc today tried to run autoconf in libsanitizer.
> However, I had the wrong version in my path, so the build died.
> 
> In gcc it is normal to use AM_MAINTAINER_MODE to avoid this problem.
> I think this is missing from libsanitizer/configure.ac due to an
> oversight.
> 
> This patch adds the missing call.
> 
> Ok?

Yes, thanks.

> 2012-11-16  Tom Tromey  <tromey@redhat.com>
> 
> 	* configure.ac: Invoke AM_MAINTAINER_MODE.
> 	* aclocal.m4, configure, Makefile.in, asan/Makefile.in,
> 	interception/Makefile.in, sanitizer_common/Makefile.in: Rebuild.
> 
> diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac
> index 76a19b6..4fb576f 100644
> --- a/libsanitizer/configure.ac
> +++ b/libsanitizer/configure.ac
> @@ -24,6 +24,7 @@ AC_SUBST(target_alias)
>  
>  AM_INIT_AUTOMAKE(foreign)
>  AM_ENABLE_MULTILIB(, ..)
> +AM_MAINTAINER_MODE
>  
>  # Calculate toolexeclibdir
>  # Also toolexecdir, though it's only used in toolexeclibdir

	Jakub
Dodji Seketeli - Nov. 16, 2012, 3:08 p.m.
Tom Tromey <tromey@redhat.com> a écrit:

> My build of gcc today tried to run autoconf in libsanitizer.
> However, I had the wrong version in my path, so the build died.
>
> In gcc it is normal to use AM_MAINTAINER_MODE to avoid this problem.
> I think this is missing from libsanitizer/configure.ac due to an
> oversight.
>
> This patch adds the missing call.
>
> Ok?

Yes.

> 2012-11-16  Tom Tromey  <tromey@redhat.com>
>
> 	* configure.ac: Invoke AM_MAINTAINER_MODE.
> 	* aclocal.m4, configure, Makefile.in, asan/Makefile.in,
> 	interception/Makefile.in, sanitizer_common/Makefile.in: Rebuild.
>

Thanks.

> diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac
> index 76a19b6..4fb576f 100644
> --- a/libsanitizer/configure.ac
> +++ b/libsanitizer/configure.ac
> @@ -24,6 +24,7 @@ AC_SUBST(target_alias)
>  
>  AM_INIT_AUTOMAKE(foreign)
>  AM_ENABLE_MULTILIB(, ..)
> +AM_MAINTAINER_MODE
>  
>  # Calculate toolexeclibdir
>  # Also toolexecdir, though it's only used in toolexeclibdir

Patch

diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac
index 76a19b6..4fb576f 100644
--- a/libsanitizer/configure.ac
+++ b/libsanitizer/configure.ac
@@ -24,6 +24,7 @@  AC_SUBST(target_alias)
 
 AM_INIT_AUTOMAKE(foreign)
 AM_ENABLE_MULTILIB(, ..)
+AM_MAINTAINER_MODE
 
 # Calculate toolexeclibdir
 # Also toolexecdir, though it's only used in toolexeclibdir