Patchwork [1/4] net: add public qemu_net_poll() function

login
register
mail settings
Submitter Stefan Hajnoczi
Date Nov. 16, 2012, 1:40 p.m.
Message ID <1353073206-31501-2-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/199637/
State New
Headers show

Comments

Stefan Hajnoczi - Nov. 16, 2012, 1:40 p.m.
The NetClientInfo .poll() callback is being called directly by
hw/vhost_net.c.  Create a public net.c function so callers do not
depend on internals.

This change is useful because later patches change net internals.  Those
changes shouldn't affect .poll() callers.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/vhost_net.c | 6 +++---
 net.c          | 7 +++++++
 net.h          | 2 ++
 3 files changed, 12 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/vhost_net.c b/hw/vhost_net.c
index 8241601..32ce40f 100644
--- a/hw/vhost_net.c
+++ b/hw/vhost_net.c
@@ -156,7 +156,7 @@  int vhost_net_start(struct vhost_net *net,
         goto fail_start;
     }
 
-    net->nc->info->poll(net->nc, false);
+    qemu_net_poll(net->nc, false);
     qemu_set_fd_handler(net->backend, NULL, NULL, NULL);
     file.fd = net->backend;
     for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
@@ -173,7 +173,7 @@  fail:
         int r = ioctl(net->dev.control, VHOST_NET_SET_BACKEND, &file);
         assert(r >= 0);
     }
-    net->nc->info->poll(net->nc, true);
+    qemu_net_poll(net->nc, true);
     vhost_dev_stop(&net->dev, dev);
 fail_start:
     vhost_dev_disable_notifiers(&net->dev, dev);
@@ -190,7 +190,7 @@  void vhost_net_stop(struct vhost_net *net,
         int r = ioctl(net->dev.control, VHOST_NET_SET_BACKEND, &file);
         assert(r >= 0);
     }
-    net->nc->info->poll(net->nc, true);
+    qemu_net_poll(net->nc, true);
     vhost_dev_stop(&net->dev, dev);
     vhost_dev_disable_notifiers(&net->dev, dev);
 }
diff --git a/net.c b/net.c
index e8ae13e..025d999 100644
--- a/net.c
+++ b/net.c
@@ -466,6 +466,13 @@  qemu_sendv_packet(NetClientState *nc, const struct iovec *iov, int iovcnt)
     return qemu_sendv_packet_async(nc, iov, iovcnt, NULL);
 }
 
+void qemu_net_poll(NetClientState *nc, bool enable)
+{
+    if (nc->info->poll) {
+        nc->info->poll(nc, enable);
+    }
+}
+
 NetClientState *qemu_find_netdev(const char *id)
 {
     NetClientState *nc;
diff --git a/net.h b/net.h
index 04fda1d..763f926 100644
--- a/net.h
+++ b/net.h
@@ -111,6 +111,8 @@  ssize_t qemu_deliver_packet_iov(NetClientState *sender,
                             int iovcnt,
                             void *opaque);
 
+void qemu_net_poll(NetClientState *nc, bool enable);
+
 void print_net_client(Monitor *mon, NetClientState *nc);
 void do_info_network(Monitor *mon);