Patchwork [U-Boot] ehci-mxc: Fix host power mask bit for i.MX35

login
register
mail settings
Submitter Benoît Thébaudeau
Date Nov. 16, 2012, 11:42 a.m.
Message ID <1605362053.1460917.1353066169872.JavaMail.root@advansee.com>
Download mbox | patch
Permalink /patch/199547/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Benoît Thébaudeau - Nov. 16, 2012, 11:42 a.m.
The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance
selection bit.

This issue has been reported by Michael Burkey <mdburkey@gmail.com> and fixed by
Christoph Fritz <chf.fritz@googlemail.com> on Linux, from which these #define-s
had been copied.

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Marek Vasut <marex@denx.de>
---
 .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefano Babic - Nov. 16, 2012, 1:12 p.m.
On 16/11/2012 12:42, Benoît Thébaudeau wrote:
> The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance
> selection bit.
> 
> This issue has been reported by Michael Burkey <mdburkey@gmail.com> and fixed by
> Christoph Fritz <chf.fritz@googlemail.com> on Linux, from which these #define-s
> had been copied.
> 
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marex@denx.de>

Hi Benoit,

> ---
>  .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> index 7c5f71c..f2642a0 100644
> --- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c
> +++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> @@ -67,7 +67,7 @@
>  #define MX35_H1_SIC_SHIFT	21
>  #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
>  #define MX35_H1_PP_BIT		(1 << 18)
> -#define MX35_H1_PM_BIT		(1 << 8)
> +#define MX35_H1_PM_BIT		(1 << 16)
>  #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
>  #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
>  #define MX35_H1_TLL_BIT		(1 << 5)

Hey, the patch was sent today to linux-arm ! Very nice you noted and
route the bug to u-boot.

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic - Nov. 19, 2012, 7:53 a.m.
On 16/11/2012 12:42, Benoît Thébaudeau wrote:
> The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance
> selection bit.
> 
> This issue has been reported by Michael Burkey <mdburkey@gmail.com> and fixed by
> Christoph Fritz <chf.fritz@googlemail.com> on Linux, from which these #define-s
> had been copied.
> 
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> index 7c5f71c..f2642a0 100644
> --- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c
> +++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> @@ -67,7 +67,7 @@
>  #define MX35_H1_SIC_SHIFT	21
>  #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
>  #define MX35_H1_PP_BIT		(1 << 18)
> -#define MX35_H1_PM_BIT		(1 << 8)
> +#define MX35_H1_PM_BIT		(1 << 16)
>  #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
>  #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
>  #define MX35_H1_TLL_BIT		(1 << 5)
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
index 7c5f71c..f2642a0 100644
--- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c
+++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
@@ -67,7 +67,7 @@ 
 #define MX35_H1_SIC_SHIFT	21
 #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
 #define MX35_H1_PP_BIT		(1 << 18)
-#define MX35_H1_PM_BIT		(1 << 8)
+#define MX35_H1_PM_BIT		(1 << 16)
 #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
 #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
 #define MX35_H1_TLL_BIT		(1 << 5)