From patchwork Fri Nov 16 10:38:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Resend] mtd: s3c2410: Fix potential NULL pointer dereference error Date: Fri, 16 Nov 2012 00:38:22 -0000 From: Sachin Kamat X-Patchwork-Id: 199538 Message-Id: <1353062302-10266-1-git-send-email-sachin.kamat@linaro.org> To: linux-mtd@lists.infradead.org Cc: sachin.kamat@linaro.org, patches@linaro.org, dwmw2@infradead.org, dedekind1@gmail.com 'set' is tested for NULL. But subsequently accessed without the check. Thus making it conditional to avoid NULL pointer dereferencing. Signed-off-by: Sachin Kamat --- drivers/mtd/nand/s3c2410.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 295e4be..bbc49c4 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -730,11 +730,14 @@ static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info, struct s3c2410_nand_mtd *mtd, struct s3c2410_nand_set *set) { - if (set) + if (set) { mtd->mtd.name = set->name; - return mtd_device_parse_register(&mtd->mtd, NULL, NULL, + return mtd_device_parse_register(&mtd->mtd, NULL, NULL, set->partitions, set->nr_partitions); + } + + return -ENODEV; } /**