From patchwork Fri Nov 16 08:32:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/3] lib: fwts_test: calloc being called with args swapped From: Colin King X-Patchwork-Id: 199515 Message-Id: <1353054776-4856-2-git-send-email-colin.king@canonical.com> To: fwts-devel@lists.ubuntu.com Date: Fri, 16 Nov 2012 08:32:54 +0000 From: Colin Ian King Fix calloc call in fwts_list_append, args were swapped which still works but we should fix this so we are allocating one fwts_list_link rather than sizeof(fwts_list_link) number of bytes. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/lib/src/fwts_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/fwts_list.c b/src/lib/src/fwts_list.c index e26b2cb..935910b 100644 --- a/src/lib/src/fwts_list.c +++ b/src/lib/src/fwts_list.c @@ -121,7 +121,7 @@ fwts_list_link *fwts_list_append(fwts_list *list, void *data) if (list == NULL) return NULL; - if ((link = calloc(sizeof(fwts_list_link),1)) == NULL) + if ((link = calloc(1,sizeof(fwts_list_link))) == NULL) return NULL; link->data = data;