Patchwork PR other/55291: Add support for GCC multilib run-time libraries to libsanitizer

login
register
mail settings
Submitter H.J. Lu
Date Nov. 15, 2012, 4:28 p.m.
Message ID <CAMe9rOqEzw55Ygoa5hb_b+_WejuaFwKXEwV66rOtJYT3MO__jA@mail.gmail.com>
Download mbox | patch
Permalink /patch/199342/
State New
Headers show

Comments

H.J. Lu - Nov. 15, 2012, 4:28 p.m.
On Thu, Nov 15, 2012 at 8:08 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
> Il 15/11/2012 17:02, H.J. Lu ha scritto:
>>>> >> I can reproduce it with --enable-version-specific-runtime-libs.  I am
>>>> >> taking a look.
>>>> >>
>>> >
>>> > I am checking in this patch.
>>> >
>> This is what I checked in.
>
> libssp et al. do not need any of this stuff.
>
> What's special about libsanitizer?
>
> Paolo

Did you mean the

it since they build libraries in subdirectories.  From
libstdc++-v3/configure.ac:

# Multilibs need MULTISUBDIR defined correctly in certain makefiles so
# that multilib installs will end up installed in the correct place.
# The testsuite needs it for multilib-aware ABI baseline files.
# To work around this not being passed down from config-ml.in ->
# srcdir/Makefile.am -> srcdir/{src,libsupc++,...}/Makefile.am, manually
# append it here.  Only modify Makefiles that have just been created.
#
Paolo Bonzini - Nov. 15, 2012, 4:30 p.m.
Il 15/11/2012 17:28, H.J. Lu ha scritto:
> On Thu, Nov 15, 2012 at 8:08 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> Il 15/11/2012 17:02, H.J. Lu ha scritto:
>>>>>>> I can reproduce it with --enable-version-specific-runtime-libs.  I am
>>>>>>> taking a look.
>>>>>>>
>>>>>
>>>>> I am checking in this patch.
>>>>>
>>> This is what I checked in.
>>
>> libssp et al. do not need any of this stuff.
>>
>> What's special about libsanitizer?
>>
>> Paolo
> 
> Did you mean the
> 
> diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac
> index 27a7f95..76a19b6 100644
> --- a/libsanitizer/configure.ac
> +++ b/libsanitizer/configure.ac
> @@ -82,6 +82,9 @@ _EOF
>     mv tmp$$ $ac_file
>     rm vpsed$$
>     echo 'MULTISUBDIR =' >> $ac_file
> +   ml_norecursion=yes
> +   . ${multi_basedir}/config-ml.in
> +   AS_UNSET([ml_norecursion])
>  ])
> 
> part?  libstdc++ and libsanitizer are only libraries which need
> it since they build libraries in subdirectories.

I see, thanks.

Paolo

Patch

diff --git a/libsanitizer/configure.ac b/libsanitizer/configure.ac
index 27a7f95..76a19b6 100644
--- a/libsanitizer/configure.ac
+++ b/libsanitizer/configure.ac
@@ -82,6 +82,9 @@  _EOF
    mv tmp$$ $ac_file
    rm vpsed$$
    echo 'MULTISUBDIR =' >> $ac_file
+   ml_norecursion=yes
+   . ${multi_basedir}/config-ml.in
+   AS_UNSET([ml_norecursion])
 ])

part?  libstdc++ and libsanitizer are only libraries which need